From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6A41F3F20E0 for ; Thu, 7 May 2026 12:53:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778158410; cv=none; b=rmc3rN0bBQx6zI7HtSQTAk+lbQDhJGr8ZbecnqIu0tzz1XW6SSZt8JC9Vygz0B3PgpfqsnJ1OhYEEJWy0RTzqf5/awcO+YSrKy2dZH2mB+CmbCj10HMm11kGzoeNTxUubPNC9XvSos3sNibUt/VLQpEXoh8hERLjxile8e5ZABQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778158410; c=relaxed/simple; bh=cXauhEjWAeS/RLvrhwl4XwFZxQ2/KcEOZKTNm+uU0jA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=AkVgxLZwW/7Q2EYZqZ1arUkRBySnb/8pcjv8LN2jmEv4cEilbgsUqXIwVfGjQoRNDG0QUKp5Zz3BWXKG/eJhx4sydQ5zmHPSurTRETQ1lFRNFvkYiQP+3Pm3lf9DEDflp4sHv10ycoz6BBwJlo2veaHhfVEbueYUwiWYA4dnsBg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=nhHkahHH; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=U6SqM/eW; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="nhHkahHH"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="U6SqM/eW" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 647C5WWD1971630 for ; Thu, 7 May 2026 12:53:27 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= QOE1jc2HnAlLzD8BFEtDOPGvG8q48G2mx4J61w97ziM=; b=nhHkahHHYBKNGNI/ 70TSQmz0x8pZrGBH0cEr7AZNe7JPwYM7y+Cpl3MI0fcnM2GCY2LiUIynfEq3A6pQ gfMgUCBzuAGsSqYEtismVzuClHnLmV3478SKuETh1N+eTA1ESjxEyMCRWIqxkdOQ amEvYHqvyNweBv1fgzhhv1rJSfIKVsDjD0ZNuvJ0ISlGBeKFpZdojzPi3SgPrXrM WRVbdnb0PJzXAJCbramwJ1uNZHY6dpUl7jG92qln/7J8J5JMlrp8wmhfrzBOIl4v tvMz5saWPaeZLLRIerxLkUX2bG2sTms8Az/7C/L6wkFQfTT4Gr5tuspoveV5tnTE impkCA== Received: from mail-vk1-f197.google.com (mail-vk1-f197.google.com [209.85.221.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e0tej8551-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 07 May 2026 12:53:27 +0000 (GMT) Received: by mail-vk1-f197.google.com with SMTP id 71dfb90a1353d-575287c467fso81840e0c.0 for ; Thu, 07 May 2026 05:53:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1778158406; x=1778763206; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=QOE1jc2HnAlLzD8BFEtDOPGvG8q48G2mx4J61w97ziM=; b=U6SqM/eWVUjoQ/I2v/o2ODaEAXL7QK+0lE/A1pt6pxt4I02a8zihGgT6M1X76codLp wjrZE3C6iWx0dznmI4LD3+J+YRDfXJgvFGKyMCL3cl4S6J/chzYxDUB8DbLjMVYVZgwH Anmk6cDyb6DT2v8irYi/NbDZEMAr/QDbGAhCZ1kC1/VTlgWSlFOBYTPPWNsQW9RkEMnH UKos2e5jixkRIsTV4kLmK3c08YJv5Zk7IyJIPgz8EqyXoWdSUrlJSoqPHUTrrNDfgcOU olV/AXu9Vb+I4vlBe9QklskSDZ0uiUnM5u9JvtrrkmICTalyNScwLNTsM0GK8RHHuU/m GIWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778158406; x=1778763206; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=QOE1jc2HnAlLzD8BFEtDOPGvG8q48G2mx4J61w97ziM=; b=kTao3Yhth4Mj7kGFc0f3deiLUyzngCTMPBqDDSxjA0V0dj7UAnuBzo3Fe5moOoQnUD yboCTvC/3RoUfAeX3HWbQAIteXglMxGSctAc1WnPWm8zlrHO666s/3aQeWxBCH4mtqX3 LDhGXHPYxrHqCGiQn9CtgNSPo5NmXDa5HeN7wI5u9oP5w717mb18sYKntprbMqZGiT0k vGrwxkpH8FOlPolPue2MbEDzBIe8lyte5IZz5547v7UFIJiN1Tx+eGdYfq8uLhnoUd84 oVQLrNjjNQ+BhKGo1TPCjOVgN/N4JW7mYuIdsoeUEuaJeah/99L2uuOYxOZUU4jy3xWJ BuAQ== X-Forwarded-Encrypted: i=1; AFNElJ8KQcAl45HbnwTuC3iTAcDNCOUqCR22m3toUInx/A7DTLE29/BIVOto79mY7BNs2hfL0ph2zUC1pMaieck=@vger.kernel.org X-Gm-Message-State: AOJu0Yw2u2d906Ia4p88TArkl7+gJmc/czj8F+LCnaSaTTkuj1QOJNkG y7ekNcMRXNv9qcnymxfC4pXvMTVS76heqJKbHDu3lkKIU6ZtSXGS7iGQgNjA4HNJgnUJU+TXOWJ E5Ch4snNwfDY7YZe6ltrLSq5anlw8/XpjXXVA+d/b55P9B3Ru8Iz8B6bG11maITaKJDs= X-Gm-Gg: AeBDiesivyRpaTH/CM/xFQ+EoqSx+dbseNHRBQgrGfRf4PbAMDZI7npM4p712SqrfGP gqWC+dFkNEQfqc4S+GQxg/jxG7MPWJjkb4iHbZFMOYMNskBEzXFDMBMR03esAplVshdLtpOzjoq RUN9NW9D1n9tLja+GFOFOfjKS2/V+Cyz8PILWUmLc2+3siigR/BuxWwyqpuTWeGaVAQNKTxN9tQ W7pDEI/4+EV7AKKx09Ymg+UBODuQxDGLQkdX9zX/M3Rkcc4hjvuj2LkBv2y2fb8rmEJ13N+wMx9 PPdKfn96A+gJHB2Om5+ToEk1TUm9lHSsWhWhbzAVH61rCQdtYmRY+sGk4fGvZP9vyctjiYD8Q94 1MUbs/OZzXTeM7/G/om3IY9xXZg6TMY7cmY3hsbQFdBxTR70QYXjLdAy3CGwQP3fefPXjFIhCBN djTbjm9YR2aezsgg== X-Received: by 2002:a05:6122:889a:b0:56d:a70d:7f06 with SMTP id 71dfb90a1353d-5755b0b591amr1001697e0c.0.1778158406200; Thu, 07 May 2026 05:53:26 -0700 (PDT) X-Received: by 2002:a05:6122:889a:b0:56d:a70d:7f06 with SMTP id 71dfb90a1353d-5755b0b591amr1001695e0c.0.1778158405772; Thu, 07 May 2026 05:53:25 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-bc8351448a8sm78652466b.50.2026.05.07.05.53.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 07 May 2026 05:53:24 -0700 (PDT) Message-ID: Date: Thu, 7 May 2026 14:53:22 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] usb: host: xhci: Allow non-Intel usb_link_tunnel_mode reporting To: Mathias Nyman , Mika Westerberg , Konrad Dybcio Cc: Thinh Nguyen , Greg Kroah-Hartman , Mathias Nyman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, usb4-upstream@oss.qualcomm.com, Raghavendra Thoorpu References: <20260505-topic-dwc3_tunneling_state-v1-0-4aaa6c3c14cb@oss.qualcomm.com> <20260505-topic-dwc3_tunneling_state-v1-1-4aaa6c3c14cb@oss.qualcomm.com> <20260505121404.GG6785@black.igk.intel.com> <02b4a4ca-c091-47b0-bae7-e38d9fa77850@oss.qualcomm.com> <803cc760-93f3-429e-bae3-669f86c07585@linux.intel.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <803cc760-93f3-429e-bae3-669f86c07585@linux.intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTA3MDEyNyBTYWx0ZWRfX2PL7eZtMlqAm XjApkyoH1VGxobwPBGg9ROrs85weDb7m542Fx3yOCIa4L47FrW8eAri611EX3F3XFh0vcMvvnOv mQvGgUmQ/xW3cwT5vugnTqJgy34Xj4Di6g9utOJlwt3NmUZftKGTn7v2nmSfTfTuFx2tmKuoJRo ZlRMzsJEy1yYQTpsL0I4s2kAhZYGJDfS0WZQLzOKiH7TEgQaYw42nS8TlaaXw1LLkVusIRXNv+H T19AwL31EkuNv7zT5hrhIE//ZnRJ9HF4eywQYQhgQkFsS0fhyWUES3iCRg4tJDAGQ7LTg7FTZLm exA5rcQL2t193FdcW1nH0IhgtTfoTYViLhRs+qbBjpmqaKUWQ76BWYMUiu0LTOu5e2EoeFgxVSE /UaffLAo63wCHwfJuKtudo48+15fgzHsCdmoMKf2g0dLz3yi6eX/8z1Q6KkLSt42QQBcUtjQwLm w7PfpMxfv565vJhlcRQ== X-Proofpoint-GUID: xI3mm9PrTzyyRs2SQvdMY6E5f68ccdeg X-Authority-Analysis: v=2.4 cv=VNbtWdPX c=1 sm=1 tr=0 ts=69fc8b47 cx=c_pps a=JIY1xp/sjQ9K5JH4t62bdg==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=EUspDBNiAAAA:8 a=mBNud2aGWxlEBhP68noA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=tNoRWFLymzeba-QzToBc:22 X-Proofpoint-ORIG-GUID: xI3mm9PrTzyyRs2SQvdMY6E5f68ccdeg X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-07_01,2026-05-06_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 spamscore=0 impostorscore=0 priorityscore=1501 malwarescore=0 bulkscore=0 lowpriorityscore=0 phishscore=0 suspectscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2605070127 On 5/7/26 2:48 PM, Mathias Nyman wrote: > On 5/7/26 13:40, Konrad Dybcio wrote: >> On 5/5/26 2:14 PM, Mika Westerberg wrote: >>> Hi, >>> >>> On Tue, May 05, 2026 at 10:55:04AM +0200, Konrad Dybcio wrote: >>>> From: Konrad Dybcio >>>> >>>> The Thunderbolt framework relies on the USB core to create device links >>>> for tunneled ports, so that the USB3 controller is only kept >>>> runtime-resumed for the duration of the tunneling. >>>> >>>> Currently, retrieving that information is only possibe on Intel XHCI >>>> hosts, through a vendor-specific capability. Extend xhci-plat to allow >>>> plumbing a custom one. >>>> >>>> Signed-off-by: Konrad Dybcio >>>> --- >>>>   drivers/usb/host/xhci-hub.c  | 4 ++-- >>>>   drivers/usb/host/xhci-plat.c | 2 ++ >>>>   drivers/usb/host/xhci-plat.h | 1 + >>>>   drivers/usb/host/xhci.c      | 6 +++++- >>>>   drivers/usb/host/xhci.h      | 5 ++++- >>>>   5 files changed, 14 insertions(+), 4 deletions(-) >>>> >>>> diff --git a/drivers/usb/host/xhci-hub.c b/drivers/usb/host/xhci-hub.c >>>> index bacd0ddd0d09..09e5da912066 100644 >>>> --- a/drivers/usb/host/xhci-hub.c >>>> +++ b/drivers/usb/host/xhci-hub.c >>>> @@ -750,7 +750,7 @@ static int xhci_exit_test_mode(struct xhci_hcd *xhci) >>>>   } >>>>     /** >>>> - * xhci_port_is_tunneled() - Check if USB3 connection is tunneled over USB4 >>>> + * xhci_port_tunnel_mode() - Check if USB3 connection is tunneled over USB4 >>>>    * @xhci: xhci host controller >>>>    * @port: USB3 port to be checked. >>>>    * >>>> @@ -764,7 +764,7 @@ static int xhci_exit_test_mode(struct xhci_hcd *xhci) >>>>    * detecting USB3 over USB4 tunnels. USB_LINK_NATIVE or USB_LINK_TUNNELED >>>>    * otherwise. >>>>    */ >>>> -enum usb_link_tunnel_mode xhci_port_is_tunneled(struct xhci_hcd *xhci, >>>> +enum usb_link_tunnel_mode xhci_port_tunnel_mode(struct xhci_hcd *xhci, >>>>                           struct xhci_port *port) >>> >>> I'm wondering if this could be: >>> >>> bool xhci_port_is_tunneled() >>> >>> becase if I understand correctly that's the only information we need e.g is >>> it going over tunnel or not. >> >> It was originally introduced as a tristate enum in: >> >> f46a6e165197 ("usb: Add tunnel_mode parameter to usb device structure") >> >> but the usefulness of USB_LINK_UNKNOWN is limited to a dev_dbg() print.. >> I don't really have strong opinions either way >> > > Tunnel detection can be tried other ways if state is USB_LINK_UNKNOWN. > > For example usb-acpi.c will try to create a tunnel if all the ACPI entries exists > that indicate a tunnel, but the current xHC doesn't support tunnel detection. Fair, I didn't consider that! Konrad