* [PATCH] ocfs2: remove unnecessary NULL check in ocfs2_grab_folios()
@ 2025-08-19 9:41 Dan Carpenter
2025-08-19 14:32 ` [External] : " Mark Tinguely
2025-08-20 5:34 ` Joseph Qi
0 siblings, 2 replies; 3+ messages in thread
From: Dan Carpenter @ 2025-08-19 9:41 UTC (permalink / raw)
To: Mark Fasheh
Cc: Joel Becker, Joseph Qi, ocfs2-devel, linux-kernel,
kernel-janitors
Smatch complains that checking "folios" for NULL doesn't make sense
because it has already been dereferenced at this point. Really passing a
NULL "folios" pointer to ocfs2_grab_folios() doesn't make sense, and
fortunately none of the callers do that. Delete the unnecessary NULL
check.
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
fs/ocfs2/alloc.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/fs/ocfs2/alloc.c b/fs/ocfs2/alloc.c
index 821cb7874685..162711cc5b20 100644
--- a/fs/ocfs2/alloc.c
+++ b/fs/ocfs2/alloc.c
@@ -6928,8 +6928,7 @@ static int ocfs2_grab_folios(struct inode *inode, loff_t start, loff_t end,
out:
if (ret != 0) {
- if (folios)
- ocfs2_unlock_and_free_folios(folios, numfolios);
+ ocfs2_unlock_and_free_folios(folios, numfolios);
numfolios = 0;
}
--
2.47.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [External] : [PATCH] ocfs2: remove unnecessary NULL check in ocfs2_grab_folios()
2025-08-19 9:41 [PATCH] ocfs2: remove unnecessary NULL check in ocfs2_grab_folios() Dan Carpenter
@ 2025-08-19 14:32 ` Mark Tinguely
2025-08-20 5:34 ` Joseph Qi
1 sibling, 0 replies; 3+ messages in thread
From: Mark Tinguely @ 2025-08-19 14:32 UTC (permalink / raw)
To: Dan Carpenter, Mark Fasheh
Cc: Joel Becker, Joseph Qi, ocfs2-devel, linux-kernel,
kernel-janitors
On 8/19/25 4:41 AM, Dan Carpenter wrote:
> Smatch complains that checking "folios" for NULL doesn't make sense
> because it has already been dereferenced at this point. Really passing a
> NULL "folios" pointer to ocfs2_grab_folios() doesn't make sense, and
> fortunately none of the callers do that. Delete the unnecessary NULL
> check.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> ---
> fs/ocfs2/alloc.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/fs/ocfs2/alloc.c b/fs/ocfs2/alloc.c
> index 821cb7874685..162711cc5b20 100644
> --- a/fs/ocfs2/alloc.c
> +++ b/fs/ocfs2/alloc.c
> @@ -6928,8 +6928,7 @@ static int ocfs2_grab_folios(struct inode *inode, loff_t start, loff_t end,
>
> out:
> if (ret != 0) {
> - if (folios)
> - ocfs2_unlock_and_free_folios(folios, numfolios);
> + ocfs2_unlock_and_free_folios(folios, numfolios);
> numfolios = 0;
> }
>
Reviewed-by: Mark Tinguely <mark.tinguely@oracle.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] ocfs2: remove unnecessary NULL check in ocfs2_grab_folios()
2025-08-19 9:41 [PATCH] ocfs2: remove unnecessary NULL check in ocfs2_grab_folios() Dan Carpenter
2025-08-19 14:32 ` [External] : " Mark Tinguely
@ 2025-08-20 5:34 ` Joseph Qi
1 sibling, 0 replies; 3+ messages in thread
From: Joseph Qi @ 2025-08-20 5:34 UTC (permalink / raw)
To: Dan Carpenter, Mark Fasheh, akpm
Cc: Joel Becker, ocfs2-devel, linux-kernel, kernel-janitors
On 2025/8/19 17:41, Dan Carpenter wrote:
> Smatch complains that checking "folios" for NULL doesn't make sense
> because it has already been dereferenced at this point. Really passing a
> NULL "folios" pointer to ocfs2_grab_folios() doesn't make sense, and
> fortunately none of the callers do that. Delete the unnecessary NULL
> check.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Acked-by: Joseph Qi <joseph.qi@linux.alibaba.com>
> ---
> fs/ocfs2/alloc.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/fs/ocfs2/alloc.c b/fs/ocfs2/alloc.c
> index 821cb7874685..162711cc5b20 100644
> --- a/fs/ocfs2/alloc.c
> +++ b/fs/ocfs2/alloc.c
> @@ -6928,8 +6928,7 @@ static int ocfs2_grab_folios(struct inode *inode, loff_t start, loff_t end,
>
> out:
> if (ret != 0) {
> - if (folios)
> - ocfs2_unlock_and_free_folios(folios, numfolios);
> + ocfs2_unlock_and_free_folios(folios, numfolios);
> numfolios = 0;
> }
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-08-20 5:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-08-19 9:41 [PATCH] ocfs2: remove unnecessary NULL check in ocfs2_grab_folios() Dan Carpenter
2025-08-19 14:32 ` [External] : " Mark Tinguely
2025-08-20 5:34 ` Joseph Qi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).