Re: [PATCH net-next] amt: fix error return code in amt_init()

Taehee Yoo
2021-11-02T14:12:31Z

Hi Yang,

On 11/2/21 10:03 PM, Yang Yingliang wrote:
> Return error code when alloc_workqueue()
> fails in amt_init().
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> ---
> drivers/net/amt.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/amt.c b/drivers/net/amt.c
> index 60a7053a9cf7..d8c9ed9f8a81 100644
> --- a/drivers/net/amt.c
> +++ b/drivers/net/amt.c
> @@ -3259,8 +3259,10 @@ static int __init amt_init(void)
> goto unregister_notifier;
>
> amt_wq = alloc_workqueue("amt", WQ_UNBOUND, 1);
> - if (!amt_wq)
> + if (!amt_wq) {
> + err = -ENOMEM;
> goto rtnl_unregister;
> + }
>
> spin_lock_init(&source_gc_lock);
> spin_lock_bh(&source_gc_lock);
>

Reviewed-by: Taehee Yoo <ap420073@gmail.com>