From: Jens Axboe <axboe@kernel.dk>
To: ZhangHui <zhanghui31@xiaomi.com>,
bvanassche@acm.org, ming.lei@redhat.com, dlemoal@kernel.org
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5] block: move non sync requests complete flow to softirq
Date: Fri, 6 Sep 2024 07:35:38 -0600 [thread overview]
Message-ID: <cf7e9e40-dcd3-4bcd-8bf5-fc1d594afae6@kernel.dk> (raw)
In-Reply-To: <20240906095414.386388-1-zhanghui31@xiaomi.com>
On 9/6/24 3:54 AM, ZhangHui wrote:
> From: zhanghui <zhanghui31@xiaomi.com>
>
> Currently, for a controller that supports multiple queues, like UFS4.0,
> the mq_ops->complete is executed in the interrupt top-half. Therefore,
> the file system's end io is executed during the request completion process,
> such as f2fs_write_end_io on smartphone.
>
> However, we found that the execution time of the file system end io
> is strongly related to the size of the bio and the processing speed
> of the CPU. Because the file system's end io will traverse every page
> in bio, this is a very time-consuming operation.
>
> We measured that the 80M bio write operation on the little CPU will
> cause the execution time of the top-half to be greater than 100ms,
> which will undoubtedly affect interrupt response latency.
>
> Let's fix this issue by moving non sync requests completion to softirq
> context, and keeping sync requests completion in the IRQ top-half context.
Didn't we already conclude that the fix for this would be on the f2fs
side?
--
Jens Axboe
prev parent reply other threads:[~2024-09-06 13:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-06 9:54 [PATCH v5] block: move non sync requests complete flow to softirq ZhangHui
2024-09-06 10:22 ` Damien Le Moal
2024-09-06 13:35 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cf7e9e40-dcd3-4bcd-8bf5-fc1d594afae6@kernel.dk \
--to=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=dlemoal@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=zhanghui31@xiaomi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).