From: Jia-Ju Bai <baijiaju1990@gmail.com>
To: pizza@shaftnet.org, kvalo@kernel.org, davem@davemloft.net,
kuba@kernel.org
Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [BUG] cw1200: possible deadlock involving three functions
Date: Tue, 8 Feb 2022 00:02:05 +0800 [thread overview]
Message-ID: <cf81c699-77ef-651d-18d0-7d8182452ff4@gmail.com> (raw)
Hello,
My static analysis tool reports a possible deadlock in the cw1200 driver
in Linux 5.16:
cw1200_probe_work()
mutex_lock(&priv->conf_mutex); --> Line 384 (Lock A)
wsm_flush_tx()
wait_event_timeout(priv->bh_evt_wq, ...) --> Line 1208 (Wait X)
cw1200_bh()
wait_event_interruptible(priv->bh_wq, ...) --> Line 524 (Wait Y)
wake_up(&priv->bh_evt_wq); --> Line 534 (Wake X)
cw1200_do_join()
mutex_lock(&priv->conf_mutex); --> Line 1238 (Lock A)
wsm_unlock_tx()
cw1200_bh_wakeup()
wake_up(&priv->bh_wq); --> Line 119 (Wake Y)
When cw1200_probe_work() is executed, "Wait X" is performed by holding
"Lock A". If cw1200_bh() is executed at this time, because "Wait Y" is
performed, "Wake X" cannot be performed to wake up "Wait X". If
cw1200_do_join() is executed at this time, because "Lock A" has already
been hold, "Wake Y" cannot be performed to wake up "Wait Y".
I find that "Wait X" is performed with a timeout, to relieve the
possible deadlock; but I think this timeout can cause inefficient execution.
I am not quite sure whether this possible problem is real and how to fix
it if it is real.
Any feedback would be appreciated, thanks :)
Best wishes,
Jia-Ju Bai
reply other threads:[~2022-02-07 16:16 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cf81c699-77ef-651d-18d0-7d8182452ff4@gmail.com \
--to=baijiaju1990@gmail.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pizza@shaftnet.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox