From: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
To: Stephan Gerhold <stephan@gerhold.net>,
Bjorn Andersson <andersson@kernel.org>
Cc: Konrad Dybcio <konrad.dybcio@linaro.org>,
Andy Gross <agross@kernel.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/6] arm64: dts: qcom: msm8916/39: Rename &blsp1_uartN -> &blsp_uartN
Date: Mon, 29 May 2023 14:21:57 +0100 [thread overview]
Message-ID: <cf8f746f-93d2-8ddc-7e6d-6324322e46e4@linaro.org> (raw)
In-Reply-To: <20230525-msm8916-labels-v1-2-bec0f5fb46fb@gerhold.net>
On 29/05/2023 13:46, Stephan Gerhold wrote:
> For some reason the BLSP UART controllers have a label with a number
> behind blsp (&blsp1_uartN) while I2C/SPI are named without (&blsp_i2cN).
> This is confusing, especially for proper node ordering in board DTs.
>
> Right now all board DTs are ordered as if the number behind blsp does
> not exist (&blsp_i2cN comes before &blsp1_uartN). Strictly speaking
> correct ordering would be the other way around ('1' comes before '_').
>
> End this confusion by giving the UART controllers consistent labels.
> There is just one BLSP on MSM8916/39 so the number is redundant.
>
> Signed-off-by: Stephan Gerhold <stephan@gerhold.net>
> ---
Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
next prev parent reply other threads:[~2023-05-29 13:22 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-29 12:46 [PATCH 0/6] arm64: dts: qcom: msm8916/39: Clean up labels Stephan Gerhold
2023-05-29 12:46 ` [PATCH 1/6] arm64: dts: qcom: msm8916: Rename &msmgpio -> &tlmm Stephan Gerhold
2023-05-29 13:20 ` Bryan O'Donoghue
2023-05-29 12:46 ` [PATCH 2/6] arm64: dts: qcom: msm8916/39: Rename &blsp1_uartN -> &blsp_uartN Stephan Gerhold
2023-05-29 13:21 ` Bryan O'Donoghue [this message]
2023-05-29 12:47 ` [PATCH 3/6] arm64: dts: qcom: msm8916/39: Use consistent name for I2C/SPI pinctrl Stephan Gerhold
2023-05-29 13:26 ` Bryan O'Donoghue
2023-05-29 12:47 ` [PATCH 4/6] arm64: dts: qcom: msm8916/39: Clean up MDSS labels Stephan Gerhold
2023-05-29 13:33 ` Bryan O'Donoghue
2023-05-29 15:00 ` Stephan Gerhold
2023-05-29 15:24 ` Bryan O'Donoghue
2023-05-29 15:26 ` Bryan O'Donoghue
2023-05-29 15:31 ` Stephan Gerhold
2023-05-29 15:52 ` Konrad Dybcio
2023-05-29 12:47 ` [PATCH 5/6] arm64: dts: qcom: pm8916: Rename &wcd_codec -> &pm8916_codec Stephan Gerhold
2023-05-29 13:47 ` Bryan O'Donoghue
2023-05-29 15:07 ` Stephan Gerhold
2023-05-29 12:47 ` [PATCH 6/6] arm64: dts: qcom: msm8916: Move aliases to boards Stephan Gerhold
2023-05-29 13:48 ` Bryan O'Donoghue
2023-05-30 0:16 ` [PATCH 0/6] arm64: dts: qcom: msm8916/39: Clean up labels Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cf8f746f-93d2-8ddc-7e6d-6324322e46e4@linaro.org \
--to=bryan.odonoghue@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stephan@gerhold.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox