From: Tom Zanussi <tom.zanussi@linux.intel.com>
To: Joe Perches <joe@perches.com>, Tom Zanussi <zanussi@kernel.org>,
rostedt@goodmis.org
Cc: tglx@linutronix.de, mhiramat@kernel.org, namhyung@kernel.org,
vedang.patel@intel.com, bigeasy@linutronix.de,
joel@joelfernandes.org, mathieu.desnoyers@efficios.com,
julia@ni.com, linux-kernel@vger.kernel.org,
linux-rt-users@vger.kernel.org
Subject: Re: [PATCH v12 01/16] tracing: Use str_has_prefix() in synth_event_create()
Date: Wed, 16 Jan 2019 09:50:49 -0600 [thread overview]
Message-ID: <cf937c481afc125e52cd44e0cfe8a54c89d3407f.camel@linux.intel.com> (raw)
In-Reply-To: <7c07519607d08c0afe448a03fb2010bce13cd77f.camel@perches.com>
Hi Joe,
On Tue, 2019-01-15 at 20:59 -0800, Joe Perches wrote:
> On Tue, 2019-01-15 at 16:05 -0600, Tom Zanussi wrote:
> > Since we now have a str_has_prefix() that returns the length, we
> > can
> > use that instead of explicitly calculating it.
>
> []
> > diff --git a/kernel/trace/trace_events_hist.c
> > b/kernel/trace/trace_events_hist.c
>
> []
> > @@ -1200,8 +1200,7 @@ static int synth_event_create(int argc, const
> > char **argv)
> >
> > /* This interface accepts group name prefix */
> > if (strchr(name, '/')) {
> > - len = sizeof(SYNTH_SYSTEM "/") - 1;
> > - if (strncmp(name, SYNTH_SYSTEM "/", len))
> > + if ((len = str_has_prefix(name, SYNTH_SYSTEM "/")) ==
> > 0)
>
> Since this is a single test, and not multiple if/else if
> blocks, I believe this would read better on two lines
>
> len = str_has_prefix(name, SYNTH_SYSTEM "/");
> if (len == 0)
>
> > return -EINVAL;
> > name += len;
> > }
>
And I was so happy to have finally found a legitimate reason to put an
assignment inside an if statement, sigh. OK, I'll change it. ;-)
Thanks,
Tom
next prev parent reply other threads:[~2019-01-16 15:50 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-15 22:05 [PATCH v12 00/16] tracing: Hist trigger snapshot and onchange additions Tom Zanussi
2019-01-15 22:05 ` [PATCH v12 01/16] tracing: Use str_has_prefix() in synth_event_create() Tom Zanussi
2019-01-16 4:59 ` Joe Perches
2019-01-16 15:50 ` Tom Zanussi [this message]
2019-01-15 22:05 ` [PATCH v12 02/16] tracing: Refactor hist trigger action code Tom Zanussi
2019-01-15 22:05 ` [PATCH v12 03/16] tracing: Make hist trigger Documentation better reflect actions/handlers Tom Zanussi
2019-01-15 22:05 ` [PATCH v12 04/16] tracing: Split up onmatch action data Tom Zanussi
2019-01-15 22:05 ` [PATCH v12 05/16] tracing: Generalize hist trigger onmax and save action Tom Zanussi
2019-01-15 22:05 ` [PATCH v12 06/16] tracing: Add conditional snapshot Tom Zanussi
2019-01-15 22:05 ` [PATCH v12 07/16] tracing: Add hist trigger snapshot() action Tom Zanussi
2019-01-15 22:05 ` [PATCH v12 08/16] tracing: Add hist trigger snapshot() action Documentation Tom Zanussi
2019-01-15 22:05 ` [PATCH v12 09/16] tracing: Add hist trigger onchange() handler Tom Zanussi
2019-01-15 22:05 ` [PATCH v12 10/16] tracing: Add hist trigger onchange() handler Documentation Tom Zanussi
2019-01-15 22:05 ` [PATCH v12 11/16] tracing: Add alternative synthetic event trace action syntax Tom Zanussi
2019-01-15 22:05 ` [PATCH v12 12/16] tracing: Add SPDX license GPL-2.0 license identifier to inter-event testcases Tom Zanussi
2019-01-15 22:05 ` [PATCH v12 13/16] tracing: Add hist trigger snapshot() action test case Tom Zanussi
2019-01-15 22:05 ` [PATCH v12 14/16] tracing: Add hist trigger onchange() handler " Tom Zanussi
2019-01-15 22:05 ` [PATCH v12 15/16] tracing: Add alternative synthetic event trace action " Tom Zanussi
2019-01-15 22:06 ` [PATCH v12 16/16] tracing: Add hist trigger action 'expected fail' " Tom Zanussi
2019-01-16 6:43 ` [PATCH v12 00/16] tracing: Hist trigger snapshot and onchange additions Namhyung Kim
2019-01-16 19:02 ` Tom Zanussi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cf937c481afc125e52cd44e0cfe8a54c89d3407f.camel@linux.intel.com \
--to=tom.zanussi@linux.intel.com \
--cc=bigeasy@linutronix.de \
--cc=joe@perches.com \
--cc=joel@joelfernandes.org \
--cc=julia@ni.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=namhyung@kernel.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=vedang.patel@intel.com \
--cc=zanussi@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox