Re: [PATCH 4/4] irqchip: Ingenic: Add support for TCU of X1000.

Zhou Yanjie
2020-03-04T11:22:44Z

Hi Marc,

On 2020年03月04日 18:58, Marc Zyngier wrote:
> On 2020-02-19 08:29, 周琰杰 wrote:
>> X1000 has a different TCU containing OST, since X1000, OST has been
>> independent of TCU. This patch is prepare for later OST driver.
>
> You keep on talking about OST (whatever that is), but never deals with
> it.

Sorry, I didn't make it clear. My intention was to explain why we need
to add an IRQCHIP_DECLARE to x1000 separately.

> Why don't you just say
>
> "Enable TCU support for Ingenic X1000, which can be supported by
> the existing driver."
>
> as this is what the patch is doing?

Yes, this patch is to ensure that TCU can be used normally when the new
OST driver is merged, thank you for your suggestion.

Thanks and best regards!

>
>>
>> Signed-off-by: 周琰杰 (Zhou Yanjie) <zhouyanjie@wanyeetech.com>
>> ---
>> drivers/irqchip/irq-ingenic-tcu.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/irqchip/irq-ingenic-tcu.c
>> b/drivers/irqchip/irq-ingenic-tcu.c
>> index 6d05cef..7a7222d 100644
>> --- a/drivers/irqchip/irq-ingenic-tcu.c
>> +++ b/drivers/irqchip/irq-ingenic-tcu.c
>> @@ -180,3 +180,4 @@ static int __init ingenic_tcu_irq_init(struct
>> device_node *np,
>> IRQCHIP_DECLARE(jz4740_tcu_irq, "ingenic,jz4740-tcu",
>> ingenic_tcu_irq_init);
>> IRQCHIP_DECLARE(jz4725b_tcu_irq, "ingenic,jz4725b-tcu",
>> ingenic_tcu_irq_init);
>> IRQCHIP_DECLARE(jz4770_tcu_irq, "ingenic,jz4770-tcu",
>> ingenic_tcu_irq_init);
>> +IRQCHIP_DECLARE(x1000_tcu_irq, "ingenic,x1000-tcu",
>> ingenic_tcu_irq_init);
>
> Otherwise,
>
> Acked-by: Marc Zyngier <maz@kernel.org>
>
> I expect this to go via the MIPS tree as a series.
>
> Thanks,
>
> M.