From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 833C21BD9E4 for ; Thu, 31 Oct 2024 12:57:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730379469; cv=none; b=co4bbGuhfBFzE76pgJdF7IqxdrykkDcRaHJ0M9f72GwUO3qkgS2/Wb/YZDCkcny0k5SZV7jxD34mHNRsP1iAdLlpaW91HedBwpfcEQ3lmIPCvDoGrmmz97vxa+D1dpgxNRykTM1bNRwfm5udm6xc3m8o6WXkShDmXRiUxbBpv5k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730379469; c=relaxed/simple; bh=z8eGgKnexZVw+VlUp9lrigcwdaRr5kcqPwNdbZBUaF4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=XeKycTvLFRbP9eDQ+4yYUTxJ5fP8QdvksSbx/8GGjLQmhac4umlfgzt6ne710WiPxRTqlSIecVXfLG1P4REbZw5wSuWCpPBCjGSRTXWCwtXVm2ngrgyhTUAQN/W3lbdUshywVdepMyManV7b1DZCNrbPMzneJ4y7JPOMn3niqgg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=I5RMaRAY; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="I5RMaRAY" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1730379466; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=e7lqBrJGwzCPo68ZE7+NaOI9FGmTKu9VV5AzlULMSGQ=; b=I5RMaRAYxqJYvD+VD7KEsw1o9wZzvDzgEAv0vxTpxl4Mxlu9HygkfmAUCVowoq/wHXwc/s ZVS5R5M/TaNHYDH37k7baxzV/chj/jMFunamDV98PmBMublUInNYVaBvV/EGnM/ONLT2Gl 3L8HzVugcTVy1uRqQZZXPy/+IVcKRWw= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-195-_VBSW0b3PBmuoFFg6_gQHg-1; Thu, 31 Oct 2024 08:57:44 -0400 X-MC-Unique: _VBSW0b3PBmuoFFg6_gQHg-1 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-4317391101aso5624015e9.2 for ; Thu, 31 Oct 2024 05:57:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730379463; x=1730984263; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=e7lqBrJGwzCPo68ZE7+NaOI9FGmTKu9VV5AzlULMSGQ=; b=o4QvbHow9QuS2Y/3ixr68Kxgn2vpFECp2+04mM9J/Us0ju6LKW6sSzDyeBrCgqDNJ5 hQwGWeK1CB3JzCgcv8/3bSEjGtaYEzymNuN9NYN3cHnVqLPX7cdrArutaFpMbFaeBipR bMShobSj61ByNBbvZzKm/hJrzLudDjboIAHTCZgIAfpM9f2o9vMo4to5UOAtp+LnZytI 2NZpKFWLI5GoXqJiSi+hZAg1VB48BACIug8gp341OVl+qBqaf7VnROtGwzTrWb+t3Htc LXlnttdAVSUjT0S3XV8ot65DyrDZgGb3wTzhgAiPzVpF9TeuGe+pG1uL0Ge7XfpP9LZO hBNQ== X-Forwarded-Encrypted: i=1; AJvYcCUpAHeSfjqem1Fes84vJ5yM38eESlwRfWcTPPFmW78nk/5GYvenb8zPCvKjPH6eQEVMQODkdjnC4dErbGA=@vger.kernel.org X-Gm-Message-State: AOJu0YwdlW42rIMagJtEhjmVykD2n4749dPapIxXnqdiwLqzETw3cQdD mPPI/rx3Jxm31JB2SMda7/CwfT71Mmf4cFtrBkxnC3PuucLq5Qs3Bse01Xc38qZY7hG4cI2I5xA /4SdQYNc6dI14J6L9jC50q+FLWdiA4ohwv9LcgDQdZ541o5UNLScUqfVpl1xA3A== X-Received: by 2002:adf:ef84:0:b0:37c:d20d:447c with SMTP id ffacd0b85a97d-38061163710mr12935227f8f.29.1730379462820; Thu, 31 Oct 2024 05:57:42 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE0J9/q3tFo4XeSLVcZXz3CbWqqLIM5gE8i1e7RDDh1jFP1bZOGOFsHQwWmb0PNuPoMuLElaw== X-Received: by 2002:adf:ef84:0:b0:37c:d20d:447c with SMTP id ffacd0b85a97d-38061163710mr12935211f8f.29.1730379462431; Thu, 31 Oct 2024 05:57:42 -0700 (PDT) Received: from ?IPV6:2003:cb:c70a:ed00:7ddf:1ea9:4f7a:91fe? (p200300cbc70aed007ddf1ea94f7a91fe.dip0.t-ipconnect.de. [2003:cb:c70a:ed00:7ddf:1ea9:4f7a:91fe]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-381c116a781sm2057848f8f.96.2024.10.31.05.57.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 31 Oct 2024 05:57:41 -0700 (PDT) Message-ID: Date: Thu, 31 Oct 2024 13:57:40 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 3/4] mm: shmem: override mTHP shmem default with a kernel parameter To: =?UTF-8?Q?Ma=C3=ADra_Canal?= , Jonathan Corbet , Andrew Morton , Hugh Dickins , Barry Song , Ryan Roberts , Baolin Wang , Lance Yang Cc: linux-mm@kvack.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-dev@igalia.com References: <20241030130308.1066299-1-mcanal@igalia.com> <20241030130308.1066299-4-mcanal@igalia.com> <2c507326-3267-431e-936a-23e2ab6a3baf@redhat.com> <899284fa-953f-48a1-af29-222d0d55881c@igalia.com> From: David Hildenbrand Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <899284fa-953f-48a1-af29-222d0d55881c@igalia.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 31.10.24 13:51, Maíra Canal wrote: > Hi David, > > On 31/10/24 09:37, David Hildenbrand wrote: >> On 30.10.24 13:58, Maíra Canal wrote: >>> Add the ``thp_shmem=`` kernel command line to allow specifying the >>> default policy of each supported shmem hugepage size. The kernel >>> parameter >>> accepts the following format: >>> >>> thp_shmem=[KMG],[KMG]:;[KMG]- >>> [KMG]: >>> >>> For example, >>> >>> thp_shmem=16K-64K:always;128K,512K:inherit;256K:advise;1M-2M:never;4M-8M:within_size >>> >>> By configuring the default policy of several shmem hugepages, the user >>> can take advantage of mTHP before it's been configured through sysfs. >>> >>> Signed-off-by: Maíra Canal >>> --- >>>   .../admin-guide/kernel-parameters.txt         |  10 ++ >>>   Documentation/admin-guide/mm/transhuge.rst    |  17 +++ >>>   mm/shmem.c                                    | 109 +++++++++++++++++- >>>   3 files changed, 135 insertions(+), 1 deletion(-) >>> > > [...] > >>> diff --git a/mm/shmem.c b/mm/shmem.c >>> index dfcc88ec6e34..c2299fa0b345 100644 >>> --- a/mm/shmem.c >>> +++ b/mm/shmem.c >>> @@ -136,6 +136,7 @@ static unsigned long huge_shmem_orders_always >>> __read_mostly; >>>   static unsigned long huge_shmem_orders_madvise __read_mostly; >>>   static unsigned long huge_shmem_orders_inherit __read_mostly; >>>   static unsigned long huge_shmem_orders_within_size __read_mostly; >>> +static bool shmem_orders_configured __initdata; >>>   #endif >>>   #ifdef CONFIG_TMPFS >>> @@ -5027,7 +5028,8 @@ void __init shmem_init(void) >>>        * Default to setting PMD-sized THP to inherit the global >>> setting and >>>        * disable all other multi-size THPs. >>>        */ >>> -    huge_shmem_orders_inherit = BIT(HPAGE_PMD_ORDER); >>> +    if (!shmem_orders_configured) >>> +        huge_shmem_orders_inherit = BIT(HPAGE_PMD_ORDER); >>>   #endif >>>       return; >>> @@ -5180,6 +5182,26 @@ struct kobj_attribute thpsize_shmem_enabled_attr = >>>   #if defined(CONFIG_TRANSPARENT_HUGEPAGE) >>> +static inline int get_order_from_str(const char *size_str) >>> +{ >>> +    unsigned long size; >>> +    char *endptr; >>> +    int order; >>> + >>> +    size = memparse(size_str, &endptr); >>> + >>> +    if (!is_power_of_2(size)) >>> +        goto err; >>> +    order = get_order(size); >>> +    if (BIT(order) & ~THP_ORDERS_ALL_FILE_DEFAULT) >>> +        goto err; >>> + >>> +    return order; >>> +err: >>> +    pr_err("invalid size %s in thp_shmem boot parameter\n", size_str); >>> +    return -EINVAL; >>> +} >> >> Hm, mostly copy and paste. You could reuse existing get_order_from_str() >> simply by passing in the supported orders and moving error reporting to >> the caller. >> > > Can I use functions from mm/huge_memory.c here? Yes, that's the idea. -- Cheers, David / dhildenb