From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77697C4167B for ; Mon, 11 Dec 2023 15:21:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344203AbjLKPVr (ORCPT ); Mon, 11 Dec 2023 10:21:47 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40602 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344024AbjLKPVp (ORCPT ); Mon, 11 Dec 2023 10:21:45 -0500 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3A437EB; Mon, 11 Dec 2023 07:21:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=YcekLTjh5+mk+lg76W+7hew/vEd7NOWaaenP7iwljuk=; b=1gHoyuRtBp6OwbKss/KRVZRgTx sitogZHN0shuA9eFrOI+8VEWHffM/iBomO4CuhwApypwyYqt/41wPkzxPuoP97UqdiylyQhzGN9X2 bOUbmeHrtcj2+cUQjbE8gzPxRetCjMcwU5kb1dIFwBM5ZxtbzatjKnHkMh4U3GGAMZS0=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1rCi6H-002dIn-QD; Mon, 11 Dec 2023 16:21:41 +0100 Date: Mon, 11 Dec 2023 16:21:41 +0100 From: Andrew Lunn To: Oleksij Rempel Cc: Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , kernel@pengutronix.de, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH net-next v1 2/2] net: phy: Add support for the DP83TG720S Ethernet PHY Message-ID: References: <20231208151159.2791794-1-o.rempel@pengutronix.de> <20231208151159.2791794-2-o.rempel@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231208151159.2791794-2-o.rempel@pengutronix.de> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 08, 2023 at 04:11:59PM +0100, Oleksij Rempel wrote: > The DP83TG720S-Q1 device is an IEEE 802.3bp and Open Alliance compliant > automotive Ethernet physical layer transceiver. > > This driver was tested with i.MX8MP EQOS (stmmac) on the MAC side and > TI same PHY on other side. > > Signed-off-by: Oleksij Rempel > --- > drivers/net/phy/Kconfig | 13 +++ > drivers/net/phy/Makefile | 1 + > drivers/net/phy/dp83tg720.c | 190 ++++++++++++++++++++++++++++++++++++ > 3 files changed, 204 insertions(+) > create mode 100644 drivers/net/phy/dp83tg720.c > > diff --git a/drivers/net/phy/Kconfig b/drivers/net/phy/Kconfig > index 25cfc5ded1da..bab10c796f24 100644 > --- a/drivers/net/phy/Kconfig > +++ b/drivers/net/phy/Kconfig > @@ -372,6 +372,19 @@ config DP83TC811_PHY > help > Supports the DP83TC811 PHY. > > +config DP83TG720_PHY > + tristate "Texas Instruments DP83TG720 Ethernet 1000Base-T1 PHY" > + help > + The DP83TG720S-Q1 is an automotive Ethernet physical layer > + transceiver compliant with IEEE 802.3bp and Open Alliance > + standards. It supports key functions necessary for > + transmitting and receiving data over both unshielded and > + shielded single twisted-pair cables. This device offers > + flexible xMII interface options, including support for both > + RGMII and SGMII MAC interfaces. It's suitable for applications > + requiring high-speed data transmission in automotive > + networking environments. > + > config DP83848_PHY > tristate "Texas Instruments DP83848 PHY" > help > diff --git a/drivers/net/phy/Makefile b/drivers/net/phy/Makefile > index f65e85c91fc1..defaef190962 100644 > --- a/drivers/net/phy/Makefile > +++ b/drivers/net/phy/Makefile > @@ -56,6 +56,7 @@ obj-$(CONFIG_DP83848_PHY) += dp83848.o > obj-$(CONFIG_DP83867_PHY) += dp83867.o > obj-$(CONFIG_DP83869_PHY) += dp83869.o > obj-$(CONFIG_DP83TC811_PHY) += dp83tc811.o > +obj-$(CONFIG_DP83TG720_PHY) += dp83tg720.o > obj-$(CONFIG_DP83TD510_PHY) += dp83td510.o Maybe it should come after CONFIG_DP83TD510_PHY in a strict sort ? I also wounder about the Kconfig, which should be sorted on the tristate string. > obj-$(CONFIG_FIXED_PHY) += fixed_phy.o > obj-$(CONFIG_ICPLUS_PHY) += icplus.o > + /* After HW reset we need to restore master/slave configuration. > + */ > + if (phydev->drv->config_aneg) { This test is a bit strange. You know it exists, its this driver and the function is there. Why not call it directly? > + ret = phydev->drv->config_aneg(phydev); > + if (ret) > + return ret; > + } Andrew --- pw-bot: cr