From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f179.google.com (mail-dy1-f179.google.com [74.125.82.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3013A37F8A8 for ; Mon, 11 May 2026 20:20:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778530813; cv=none; b=BQoUrqp0WQb5D3B/wM52sJm78JtxlaU74IQYZemaiATLXZ9evbIV5rP+sCdl1MHnut8FJPQ3GNAVpOKt6vRG5/vEktON3HqvXCRRQsCQVZjjx/NQpsOlJhY8MVohHiv+cZuMxNNK5phPlN/yegsCVPQJ1HkoofOJye7r7ewWHJA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778530813; c=relaxed/simple; bh=QlCoJgzFuDkzKyD4vPssOlod5ioow6DwDwHxhzMVUXk=; h=From:Message-ID:Date:MIME-Version:Subject:To:Cc:References: In-Reply-To:Content-Type; b=VN7TRM4u4H36P3oYQGn/WT9dDfoFcf+Pwa2atRSBvNBwDEbaYcjgC7MRv8/VC22P3RZ2iAUUk6ld+AcBP6ybRbAULU3q/cV/CVM9OXHlE2vRBc4KxghZTDuUmqk3MOLzN2GKcEbzoxG2bm0njBYEqHItOOh57uXZq53JQUp/AGs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=embeddedts.com; spf=pass smtp.mailfrom=embeddedts.com; dkim=pass (1024-bit key) header.d=embeddedts.com header.i=@embeddedts.com header.b=gN/k7MhQ; arc=none smtp.client-ip=74.125.82.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=embeddedts.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=embeddedts.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=embeddedts.com header.i=@embeddedts.com header.b="gN/k7MhQ" Received: by mail-dy1-f179.google.com with SMTP id 5a478bee46e88-2ef2a1cc06dso8081688eec.0 for ; Mon, 11 May 2026 13:20:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embeddedts.com; s=google; t=1778530811; x=1779135611; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:user-agent:mime-version:date:message-id:from:from:to :cc:subject:date:message-id:reply-to; bh=qQPJFpBF/Y6ESwRVchtItkryNrsx2h5o1QJ9xXHHvWE=; b=gN/k7MhQZlmt+HmCJ0h5lM7ah0m+TNKxkHec5B9x5z9zDBX+GEXUGOTyE06eNQR2VL omWFOzsRu3y2yo9m50iC7xrYL+ti5gNXvbvh03dFhyyX/hA1QixcOFFTPhtwik2N3Ug3 qARBstLTu5cfdz0Dqwx3x90+IprJ6axjvQRGA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778530811; x=1779135611; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:user-agent:mime-version:date:message-id:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=qQPJFpBF/Y6ESwRVchtItkryNrsx2h5o1QJ9xXHHvWE=; b=ecUH2VMaTH+uK0yC+SJzbV40PARbRSwsiqNB09euPSIBguNfGWr3aoTFkVKStdG0Ze vHkYKkIi1iUq6P7ZoATN2agtGdPCTNQkC6aEsY5fT0aTne/blgJYfYSOXkf0J3pE6xf5 lhHiQqUW1wYEZsPz0YJwq/WAf03wfxoCpmeOIvhMGY70cPfmq/vqGc5Jzdvmi0tRjEzW bnnXrGlakCIqzwTX23e/f53nfPXGKKc2h/TKIW6CIwjxGu7Q+5U44gU6FxAhgrypCzAJ Q7vGvkY6NMrX+KIXxBybm5SX4IN6JkFFAKtBoVfXSKR72HGWvmsPktA0hTHpCmk4FjAe zcTw== X-Forwarded-Encrypted: i=1; AFNElJ8972XQsNewrvJlOZx09p6waCQaPAEOk0Q4j/yrTyNpCoSHNgxkt47ft48Afu0T7AaXkG6dqgLnTdPyUDY=@vger.kernel.org X-Gm-Message-State: AOJu0YwO9BJeDC+sVxhKUfCzFmnYP4s6jYx4Y5oTOB9BgW7O2pIDCOFb FrrxIiuU8z2DnehSKADrQRIZQfTE4nydDkrvzntih2A/KVYKR9/a1oBtHRggk4KlVvbm8SJw3PY MkJvXp0tksA== X-Gm-Gg: Acq92OEFoTHoIht5OcUBjUqEJ/Sx9Cu21GBlHpI5xiKyKS1MOitYt0mhyQWXdZ+TfHm Pi5yO4RA2NYAgOFCA5MKI5uzLA9fl+4FdVPWwOIp+IH7RlcInKmn/rWw4nKdeQPx67T2gWPiyig HmUcepzEvIFzu+DXo7Rhu5Uzr5+Lii1b7x0AyLtK9+msRPpdU4JVAr+ou6+gz1tpU1QjHCP4yci XmLtekQ2OGvg9O9Ec6Y7LRJF5o9a8XZ3GIg5w7/PPMy72/J7+ZpnNGYkxOw8QxJQFXsjC9gRbXw n6gGq86/pPISGrSr8bx4P4gPKsINvN5AbeNLAB2dVArgU+Pt6vYeSS4Yu30ku5PLT2I/1Rzt1Y1 UtSnVXkVl/I1JPczNjvYDzbjQEKtivJ3znjbIQ3z9tkol9Jw/I4/Sjdp7HtkoY6hQGEPwSUasKc S8rmr9wedYWGnZf6m+ToAVfxMKsaJcep6AgdkSOsvriCJlT9Bvf8jfQFic+S+y4JtZ2kHtl+W62 xyxsa0N8JbHYak3Kb2WgAfY0RrQS6HjFK8vpJCebuGE47iWkD32N4Ryy8FGbngvxDDE3A== X-Received: by 2002:a05:7301:1008:b0:2d9:b466:5e19 with SMTP id 5a478bee46e88-2fb4b733d76mr5616023eec.21.1778530811190; Mon, 11 May 2026 13:20:11 -0700 (PDT) Received: from [10.10.10.191] ([184.3.231.126]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2f8860ce1bfsm15471585eec.9.2026.05.11.13.20.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 11 May 2026 13:20:10 -0700 (PDT) From: Kris Bahnsen X-Google-Original-From: Kris Bahnsen Message-ID: Date: Mon, 11 May 2026 13:20:08 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] Input: ads7846 - consolidate coordinate filtering logic To: Dmitry Torokhov Cc: linux-input@vger.kernel.org, Aaro Koskinen , Mark Featherston , Marek Vasut , linux-kernel@vger.kernel.org References: Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Dmitry, On 5/7/26 12:35 PM, Dmitry Torokhov wrote: > Hi Kris, > > On Thu, May 07, 2026 at 10:48:57AM -0700, Kris Bahnsen wrote: >> On 5/4/26 9:54 PM, Dmitry Torokhov wrote: >>> The ads7846 driver has two separate filtering functions, >>> ads7846_filter() and ads7846_filter_one(), for the full-duplex and >>> half-duplex SPI paths, respectively. >>> >>> They can be consolidated by extracting the core filtering logic for a >>> single command into a helper function, ads7846_filter_cmd(), which >>> iterates from l->skip to l->count. The half-duplex setup function is >>> updated to set l->skip = l->count - 1 so that the helper only processes >>> the last sample, preserving the original half-duplex behavior. >>> >>> Assisted-by: Gemini:gemini-3.1-pro >>> Signed-off-by: Dmitry Torokhov >>> --- >>> >>> Not tested so will appreciate if someone could give it a spin. >> >> Forgive my ignorance, but I am unsure of the base commit this applies >> to and I'm unable to apply it to current HEAD of linux, linux-next, >> or your input tree. >> >> I also am not easily able to test this if it doesn't cleanly apply >> to the latest LTS, but will do what I can once I know what other >> patches I would need to pull in to our tree. > > I think if you pull 'next' branch of my tree, then the following patches > seem to apply cleanly on 7.0: > > c68bc840f06c ("Input: ads7846 - restore half-duplex support") > 011bdf9f3a9d ("Input: ads7846 - consolidate coordinate filtering logic") Please confirm that the referenced commits are pushed and that I am using the correct remote URLs. I am unable to find the referenced commits still: $ git remote -v input git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git (fetch) input git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git (push) next git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git (fetch) next git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git (push) [...] $ git fetch next $ git fetch input $ git show c68bc840f06c fatal: ambiguous argument 'c68bc840f06c': unknown revision or path not in the working tree. $ git show 011bdf9f3a9d fatal: ambiguous argument '011bdf9f3a9d': unknown revision or path not in the working tree. Apologies in advance if I am missing something obvious. > I hope they also build ;) > > c68bc840f06c should appear in linux-next soon too. > > Thanks. > -- Kris Bahnsen Software Engineer embeddedTS