From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Stephan Gerhold <stephan.gerhold@kernkonzept.com>,
Georgi Djakov <djakov@kernel.org>
Cc: Bjorn Andersson <andersson@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Adam Skladowski <a39.skl@gmail.com>
Subject: Re: [PATCH v2 2/2] interconnect: qcom: Add MSM8909 interconnect provider driver
Date: Wed, 20 Dec 2023 13:34:33 +0100 [thread overview]
Message-ID: <cfe3ee21-e1c7-4e54-b544-43cdc8d64bfa@linaro.org> (raw)
In-Reply-To: <20231220-icc-msm8909-v2-2-3b68bbed2891@kernkonzept.com>
On 20.12.2023 11:38, Stephan Gerhold wrote:
> From: Adam Skladowski <a39.skl@gmail.com>
>
> Add driver for interconnect busses found in MSM8909 based platforms.
> The topology consists of three NoCs that are partially controlled by
> a RPM processor.
>
> In the downstream/vendor kernel from Qualcomm there is an additional
> "mm-snoc". However, it actually ends up using the same RPM "snoc_clk"
> as the normal "snoc". It looks like this is actually the same NoC
> in hardware and the "mm-snoc" was only defined to assign a different
> "qcom,util-fact" to increase bandwidth requests by a static margin.
> In mainline we can represent this by assigning the equivalent "ab_coeff"
> to all the nodes that are part of "mm-snoc" downstream.
>
> Signed-off-by: Adam Skladowski <a39.skl@gmail.com>
> [Stephan: Drop separate mm-snoc that exists downstream since it's
> actually the same NoC as SNoC in hardware, add qos_offset for BIMC,
> add ab_coeff for mm-snoc nodes and BIMC]
> Signed-off-by: Stephan Gerhold <stephan.gerhold@kernkonzept.com>
> ---
The hard work we put into fixing up smd rpm icc paid off.. thanks!
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
prev parent reply other threads:[~2023-12-20 12:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-20 10:38 [PATCH v2 0/2] interconnect: qcom: Add MSM8909 interconnect provider driver Stephan Gerhold
2023-12-20 10:38 ` [PATCH v2 1/2] dt-bindings: interconnect: Add Qualcomm MSM8909 DT bindings Stephan Gerhold
2023-12-20 10:38 ` [PATCH v2 2/2] interconnect: qcom: Add MSM8909 interconnect provider driver Stephan Gerhold
2023-12-20 12:34 ` Konrad Dybcio [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cfe3ee21-e1c7-4e54-b544-43cdc8d64bfa@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=a39.skl@gmail.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=djakov@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=stephan.gerhold@kernkonzept.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox