From: Doug Berger <opendmb@gmail.com>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Keguang Zhang <keguang.zhang@gmail.com>,
Alban Bedel <albeu@free.fr>,
Florian Fainelli <florian.fainelli@broadcom.com>,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Paul Walmsley <paul.walmsley@sifive.com>,
Samuel Holland <samuel.holland@sifive.com>,
Yixun Lan <dlan@gentoo.org>, Andy Shevchenko <andy@kernel.org>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mips@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
linux-riscv@lists.infradead.org, spacemit@lists.linux.dev,
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Subject: Re: [PATCH v2 07/15] gpio: brcmstb: use new generic GPIO chip API
Date: Thu, 11 Sep 2025 12:50:47 -0700 [thread overview]
Message-ID: <cfe7bc19-763f-4e92-b1ae-355c661bcc19@gmail.com> (raw)
In-Reply-To: <CAMRc=MfZ5ss8Gd_TTPV8EYSv04ENp_C26b3=wukO+UTy_boXUA@mail.gmail.com>
On 9/11/2025 12:56 AM, Bartosz Golaszewski wrote:
> On Thu, Sep 11, 2025 at 2:11 AM Doug Berger <opendmb@gmail.com> wrote:
>>
>>>
>>> @@ -700,7 +707,8 @@ static int brcmstb_gpio_probe(struct platform_device *pdev)
>>> * be retained from S5 cold boot
>>> */
>>> need_wakeup_event |= !!__brcmstb_gpio_get_active_irqs(bank);
>>> - gc->write_reg(reg_base + GIO_MASK(bank->id), 0);
>>> + gpio_generic_write_reg(&bank->chip,
>>> + reg_base + GIO_MASK(bank->id), 0);
>>>
>>> err = gpiochip_add_data(gc, bank);
>>> if (err) {
>>>
>> I suppose I'm OK with all of this, but I'm just curious about the longer
>> term plans for the member accesses. Is there an intent to have helpers
>> for things like?:
>> chip.gc.offset
>> chip.gc.ngpio
>
> I don't think so. It would require an enormous effort and these fields
> in struct gpio_chip are pretty stable so there's no real reason for
> it.
>
> Bart
Ok, so assuming struct gpio_chip is sticking around long term that makes
sense to me.
Thanks!
Acked-by: Doug Berger <opendmb@gmail.com>
next prev parent reply other threads:[~2025-09-11 19:50 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-10 7:12 [PATCH v2 00/15] gpio: replace legacy bgpio_init() with its modernized alternative - part 4 Bartosz Golaszewski
2025-09-10 7:12 ` [PATCH v2 01/15] gpio: loongson1: allow building the module with COMPILE_TEST enabled Bartosz Golaszewski
2025-09-10 7:12 ` [PATCH v2 02/15] gpio: loongson1: use new generic GPIO chip API Bartosz Golaszewski
2025-09-10 7:12 ` [PATCH v2 03/15] gpio: hlwd: " Bartosz Golaszewski
2025-09-10 7:12 ` [PATCH v2 04/15] gpio: ath79: " Bartosz Golaszewski
2025-09-10 7:12 ` [PATCH v2 05/15] gpio: ath79: use the generic GPIO chip lock for IRQ handling Bartosz Golaszewski
2025-09-10 7:12 ` [PATCH v2 06/15] gpio: xgene-sb: use generic GPIO chip register read and write APIs Bartosz Golaszewski
2025-09-10 7:12 ` [PATCH v2 07/15] gpio: brcmstb: use new generic GPIO chip API Bartosz Golaszewski
2025-09-10 22:05 ` Florian Fainelli
2025-09-11 0:11 ` Doug Berger
2025-09-11 7:56 ` Bartosz Golaszewski
2025-09-11 8:02 ` Andy Shevchenko
2025-09-11 19:50 ` Doug Berger [this message]
2025-09-10 7:12 ` [PATCH v2 08/15] gpio: mt7621: " Bartosz Golaszewski
2025-09-10 7:12 ` [PATCH v2 09/15] gpio: mt7621: use the generic GPIO chip lock for IRQ handling Bartosz Golaszewski
2025-09-10 7:12 ` [PATCH v2 10/15] gpio: menz127: use new generic GPIO chip API Bartosz Golaszewski
2025-09-10 7:12 ` [PATCH v2 11/15] gpio: sifive: " Bartosz Golaszewski
2025-09-11 0:37 ` Samuel Holland
2025-09-11 7:58 ` Bartosz Golaszewski
2025-09-10 7:12 ` [PATCH v2 12/15] gpio: spacemit-k1: " Bartosz Golaszewski
2025-09-10 7:12 ` [PATCH v2 13/15] gpio: sodaville: " Bartosz Golaszewski
2025-09-10 7:19 ` Andy Shevchenko
2025-09-10 7:28 ` Bartosz Golaszewski
2025-09-10 7:12 ` [PATCH v2 14/15] gpio: mmio: " Bartosz Golaszewski
2025-09-10 7:12 ` [PATCH v2 15/15] gpio: move gpio-mmio-specific fields out of struct gpio_chip Bartosz Golaszewski
2025-09-10 21:32 ` [PATCH v2 00/15] gpio: replace legacy bgpio_init() with its modernized alternative - part 4 Linus Walleij
2025-09-11 7:38 ` Bartosz Golaszewski
2025-09-12 7:33 ` Linus Walleij
2025-09-12 7:26 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cfe7bc19-763f-4e92-b1ae-355c661bcc19@gmail.com \
--to=opendmb@gmail.com \
--cc=albeu@free.fr \
--cc=andy@kernel.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=bartosz.golaszewski@linaro.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=brgl@bgdev.pl \
--cc=dlan@gentoo.org \
--cc=florian.fainelli@broadcom.com \
--cc=keguang.zhang@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=paul.walmsley@sifive.com \
--cc=samuel.holland@sifive.com \
--cc=spacemit@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox