From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6E99B2D3ED2 for ; Fri, 24 Apr 2026 15:12:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777043564; cv=none; b=ZhOhma7VzaaeL4FYuRWhCRJsKGXaS6aRaqqAgx8SfR7TAR+5mNzgOX7WRo0UYhK0HxkFiP4FpLFhy7q5y/yJj8OaFdPneGLKpg6B5PfxE1MCOOXWRd0rlylWthMNmpHDm8ehatiAixDUfRKgoHjEMLtcC/dDJAC3KtG1wSd8Si0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777043564; c=relaxed/simple; bh=5XDKAxu8Xq1TVY6QbxiDtMURF8o8Sc8i5C25fq9XWJ4=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=pKeFHZQdb2Ldx2dqgOWeWt3f9wiuDhvVqHWDoXtVhMXFkHo/3b0ta30LoSXW/vXo2P+OPm7MelcuQ9bd0AsotmwnD2qu28l2k/tNDhKdja6pY5CuwinR9wwOAddFz0ReBcPGbsxTknBuO3uhmRzbNw4WY6MZLesW//x0aEzBQAo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=F4qoZJqq; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="F4qoZJqq" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-488b0e1b870so130611835e9.2 for ; Fri, 24 Apr 2026 08:12:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1777043560; x=1777648360; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=JlPy3eW0kbNMua8eHVUnVBy11sqyRv1hpFqPENpVf9I=; b=F4qoZJqqmUrs2GX+PhdaDhKCnKPgXYiqVW0zFoZLGGcvZ/mjoM0XN8PlXRgzVick2D mRMoG7AeM6gF9D2ZBPt2x+6ICp5i7KFR2Zi2d+TT/RER9bOF491cYVuutkZOVx8PUYR0 dYPmD3ss0MVLnhiQ8h9DhQAo7zP/JZHH/QZMtxc/8sj9zBaR82UVMmhxuC0sdpEVEsAE 84wl87TiFxlUVlNbfDhJSuo4sw4D0yq09u0KjpFJTh4Uzw+pnHxlzZ0wvuOuN2aKXtRS FzDZc6qipjfnN92ZpHbXkHnWDI6uK7FZVjui/NCH6ISK0mTuuAgrCv3S3gKLGnN13FiJ ZBLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777043560; x=1777648360; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JlPy3eW0kbNMua8eHVUnVBy11sqyRv1hpFqPENpVf9I=; b=E2HJibm0/cKrKNMrzVaiOc0xhXayLYsH33nyAETURetSvDdMnb6Epp8ap/cblsPpGL Maz4Ee7TUB15395F8QtxhEucJYYGdTxpGD+QIefHTezNsKh+sHmB37vgx72cp4NbZhXp KvVPMDMATi7CaWLG3fFAjHclcsEHYhVSU0VHGMWcM8ux96WPj95kQ6dWzKLuxWzBqYfX J72yfYBJq/KWpQp2txyBDr1weoiHgeS4v8n0xeDb0wQfszsIX7qDB3LVszdUymGQi8fO BhMA0HtpFfOR+PP7cUKG7PpT8tqQPGQs+Ji5ZPtILqGZixRtshVjvimyxB6Udrqaf1zg n3iw== X-Forwarded-Encrypted: i=1; AFNElJ8CjEf3BkX4Cekaor95cMH0Yvnq+yDBB8ZwOknjiNtrLpTTSICv0Eiykd/nQlYe3u70NvymupPTwLoK3Eo=@vger.kernel.org X-Gm-Message-State: AOJu0Yzz8dI2NlHUJ8fMnfmJlQIAzSSSYRDYwbGrGyA8bhlaNxrPyqpx EAUFB0Aq7eL2x59dlikrc7NqxLxg3i0CU9HK0Jstt+vjeOguy62/Jy0hJTzgpYbtXH0= X-Gm-Gg: AeBDieuQj6bBg47oduIMqKhuTUBifv2aXuf/pxgua7E5UINdWcVpXeHvzfTBId7GDco 51Z2Zi0A39J13wYRbnusrCfOeaJcx5Ja0DgHzBLoMWe/MFpLbnKzkom694popmKreTN0+IqRo2F meckaDyKUMOTtB6inO3SDtJhtoiUjtuw8dmzhdc+iSR61qDCXVaOF4HSs4b1+ZcHbRDBDYz8Sm2 0M3H9cJc1OYGQPownTrnUlvOR09oIMF4qurG5qj18cYQkyIumZ1qY32esqOsMtduK09E7srZ30X jj+GgE7sfSxgstu+U/z/ehW3sL5SjOMhFG2D4T9+OvVi0PBQWimA1TsbkniCdsbKkhVhc0eduYt lRF/YP8wB1Pb+1W1WCfzuvbGAXE6uZj1r6NEhyDNz3lqD0hMIYylhbbh+ms/uHnh7j7y9rigHgS v+VUXs7qu1ztaGNBCgHJDfDYCEIpOaZgtgQURPklpbQaL5cMk+EsQ6uzaNz8sPaHIJNNGBgb2Ns KyzfXCvO6Z0HwXPVA== X-Received: by 2002:a05:600d:16:b0:489:19e9:b139 with SMTP id 5b1f17b1804b1-48919e9b29fmr249420635e9.1.1777043559595; Fri, 24 Apr 2026 08:12:39 -0700 (PDT) Received: from ?IPV6:2a01:e0a:106d:1080:608c:c052:cffc:495b? ([2a01:e0a:106d:1080:608c:c052:cffc:495b]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4412150a071sm25224946f8f.21.2026.04.24.08.12.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 24 Apr 2026 08:12:39 -0700 (PDT) Message-ID: Date: Fri, 24 Apr 2026 17:12:38 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Neil Armstrong Reply-To: Neil Armstrong Subject: Re: [PATCH v5 5/8] thermal: khadas-mcu-fan: Add fan config from platform data Add regulator support To: linux-kernel-dev@aliel.fr, Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andi Shyti , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Beniamino Galvani , "Rafael J. Wysocki" , Daniel Lezcano , Zhang Rui , Lukasz Luba , Liam Girdwood , Mark Brown Cc: linux-amlogic@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org References: <20260424-add-mcu-fan-khadas-vim4-v5-0-afcfa7157b23@aliel.fr> <20260424-add-mcu-fan-khadas-vim4-v5-5-afcfa7157b23@aliel.fr> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: <20260424-add-mcu-fan-khadas-vim4-v5-5-afcfa7157b23@aliel.fr> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 4/24/26 16:17, Ronald Claveau via B4 Relay wrote: > From: Ronald Claveau > > Replace the hardcoded MAX_LEVEL constant and fan register > with values read from platform_data (fan_reg, max_level), > as new MCUs need different values. > > Optionally acquire and enable a "fan" regulator supply > at probe time and on resume, > so boards that gate fan power through a regulator are handled. > > Signed-off-by: Ronald Claveau > --- > drivers/thermal/khadas_mcu_fan.c | 37 ++++++++++++++++++++++++++++++------- > 1 file changed, 30 insertions(+), 7 deletions(-) > > diff --git a/drivers/thermal/khadas_mcu_fan.c b/drivers/thermal/khadas_mcu_fan.c > index d35e5313bea41..5603fa099a858 100644 > --- a/drivers/thermal/khadas_mcu_fan.c > +++ b/drivers/thermal/khadas_mcu_fan.c > @@ -13,13 +13,15 @@ > #include > #include > #include > - > -#define MAX_LEVEL 3 > +#include > > struct khadas_mcu_fan_ctx { > struct khadas_mcu *mcu; > + unsigned int fan_reg; > unsigned int level; > + unsigned int max_level; > struct thermal_cooling_device *cdev; > + struct regulator *power; > }; > > static int khadas_mcu_fan_set_level(struct khadas_mcu_fan_ctx *ctx, > @@ -27,8 +29,7 @@ static int khadas_mcu_fan_set_level(struct khadas_mcu_fan_ctx *ctx, > { > int ret; > > - ret = regmap_write(ctx->mcu->regmap, KHADAS_MCU_CMD_FAN_STATUS_CTRL_REG, > - level); > + ret = regmap_write(ctx->mcu->regmap, ctx->fan_reg, level); > if (ret) > return ret; > > @@ -40,7 +41,9 @@ static int khadas_mcu_fan_set_level(struct khadas_mcu_fan_ctx *ctx, > static int khadas_mcu_fan_get_max_state(struct thermal_cooling_device *cdev, > unsigned long *state) > { > - *state = MAX_LEVEL; > + struct khadas_mcu_fan_ctx *ctx = cdev->devdata; > + > + *state = ctx->max_level; > > return 0; > } > @@ -61,7 +64,7 @@ khadas_mcu_fan_set_cur_state(struct thermal_cooling_device *cdev, > { > struct khadas_mcu_fan_ctx *ctx = cdev->devdata; > > - if (state > MAX_LEVEL) > + if (state > ctx->max_level) > return -EINVAL; > > if (state == ctx->level) > @@ -78,6 +81,7 @@ static const struct thermal_cooling_device_ops khadas_mcu_fan_cooling_ops = { > > static int khadas_mcu_fan_probe(struct platform_device *pdev) > { > + const struct khadas_mcu_fan_pdata *pdata = dev_get_platdata(&pdev->dev); > struct khadas_mcu *mcu = dev_get_drvdata(pdev->dev.parent); > struct thermal_cooling_device *cdev; > struct device *dev = &pdev->dev; > @@ -87,7 +91,21 @@ static int khadas_mcu_fan_probe(struct platform_device *pdev) > ctx = devm_kzalloc(dev, sizeof(*ctx), GFP_KERNEL); > if (!ctx) > return -ENOMEM; > + > ctx->mcu = mcu; > + ctx->fan_reg = pdata->fan_reg; > + ctx->max_level = pdata->max_level; > + > + ctx->power = devm_regulator_get(dev->parent, "fan"); > + if (IS_ERR(ctx->power)) > + return PTR_ERR(ctx->power); > + > + ret = regulator_enable(ctx->power); > + if (ret) { > + dev_err(dev, "Failed to enable fan power supply: %d\n", ret); > + return ret; > + } > + > platform_set_drvdata(pdev, ctx); > > cdev = devm_thermal_of_cooling_device_register(dev->parent, > @@ -124,12 +142,17 @@ static int khadas_mcu_fan_suspend(struct device *dev) > > ctx->level = level_save; > > - return 0; > + return regulator_disable(ctx->power); > } > > static int khadas_mcu_fan_resume(struct device *dev) > { > struct khadas_mcu_fan_ctx *ctx = dev_get_drvdata(dev); > + int ret; > + > + ret = regulator_enable(ctx->power); > + if (ret) > + return ret; > > return khadas_mcu_fan_set_level(ctx, ctx->level); > } > Reviewed-by: Neil Armstrong