From: Krzysztof Kozlowski <krzk@kernel.org>
To: Akhil R <akhilrajeev@nvidia.com>,
herbert@gondor.apana.org.au, davem@davemloft.net,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
thierry.reding@gmail.com, jonathanh@nvidia.com,
linux-tegra@vger.kernel.org
Subject: Re: [PATCH 1/5] dt-bindings: crypto: Add Tegra SE DT binding doc
Date: Wed, 13 Dec 2023 20:45:51 +0100 [thread overview]
Message-ID: <cffa9a73-802a-4453-826e-9870ee2e735d@kernel.org> (raw)
In-Reply-To: <20231213122030.11734-2-akhilrajeev@nvidia.com>
On 13/12/2023 13:20, Akhil R wrote:
> Add DT binding document for Tegra Security Engine.
> The AES and HASH algorithms are handled independently by separate
> engines within the Security Engine. These engines are registered
> as two separate crypto engine drivers.
>
> Signed-off-by: Akhil R <akhilrajeev@nvidia.com>
> ---
NAK, not tested.
A nit, subject: drop second/last, redundant "binding doc". The
"dt-bindings" prefix is already stating that these are bindings.
Please use scripts/get_maintainers.pl to get a list of necessary people
and lists to CC. It might happen, that command when run on an older
kernel, gives you outdated entries. Therefore please be sure you base
your patches on recent Linux kernel.
You missed at least devicetree list (maybe more), so this won't be
tested by automated tooling. Performing review on untested code might be
a waste of time, thus I will skip this patch entirely till you follow
the process allowing the patch to be tested.
Please kindly resend and include all necessary To/Cc entries.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-12-13 19:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-13 12:20 [PATCH 0/5] Add Tegra Security Engine driver Akhil R
2023-12-13 12:20 ` [PATCH 1/5] dt-bindings: crypto: Add Tegra SE DT binding doc Akhil R
2023-12-13 19:45 ` Krzysztof Kozlowski [this message]
2023-12-13 12:20 ` [PATCH 2/5] gpu: host1x: Add Tegra SE to SID table Akhil R
2023-12-13 12:20 ` [PATCH 3/5] crypto: tegra: Add Tegra Security Engine driver Akhil R
2023-12-13 19:53 ` Krzysztof Kozlowski
2023-12-19 12:59 ` Akhil R
2023-12-14 2:50 ` kernel test robot
2023-12-14 5:19 ` kernel test robot
2023-12-14 7:12 ` kernel test robot
2023-12-14 18:08 ` kernel test robot
2023-12-13 12:20 ` [PATCH 4/5] arm64: defconfig: Enable Tegra Security Engine Akhil R
2023-12-13 12:20 ` [PATCH 5/5] arm64: tegra: Add Tegra Security Engine DT nodes Akhil R
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cffa9a73-802a-4453-826e-9870ee2e735d@kernel.org \
--to=krzk@kernel.org \
--cc=akhilrajeev@nvidia.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=jonathanh@nvidia.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox