From: Kalin KOZHUHAROV <kalin@thinrope.net>
To: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] removes unnessary print of space
Date: Mon, 06 Sep 2004 16:57:55 +0900 [thread overview]
Message-ID: <chh5a5$tle$1@sea.gmane.org> (raw)
In-Reply-To: <413C0CC5.4000807@sw.ru>
Kirill Korotaev wrote:
> This patch removes unnessary print of space in bust_spinlocks().
> printk("") wakeups klogd as well, no need to print a space
> and make a mess.
>
I may be just a newbie, but why call prink with no arguments?
Does it do something?
> ------------------------------------------------------------------------
>
> --- ./arch/i386/mm/fault.c.printk 2004-08-14 14:54:46.000000000 +0400
> +++ ./arch/i386/mm/fault.c 2004-09-06 11:02:32.730550352 +0400
> @@ -51,7 +51,7 @@ void bust_spinlocks(int yes)
> * a poke. Hold onto your hats...
> */
> console_loglevel = 15; /* NMI oopser may have shut the console up */
> - printk(" ");
> + printk("");
> console_loglevel = loglevel_save;
> }
>
Kalin.
--
|| ~~~~~~~~~~~~~~~~~~~~~~ ||
( ) http://ThinRope.net/ ( )
|| ______________________ ||
next prev parent reply other threads:[~2004-09-06 8:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-06 7:07 [PATCH] removes unnessary print of space Kirill Korotaev
2004-09-06 7:08 ` Andrew Morton
2004-09-06 8:34 ` Kirill Korotaev
2004-09-06 8:29 ` Andrew Morton
2004-09-06 16:33 ` Randy.Dunlap
2004-09-06 12:17 ` Chris Wedgwood
2004-09-06 7:57 ` Kalin KOZHUHAROV [this message]
2004-09-06 9:03 ` Tonnerre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='chh5a5$tle$1@sea.gmane.org' \
--to=kalin@thinrope.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox