Re: [PATCH] Request driver inclusion - acer aspire one fan control

[Peter Feuerer <peter@piie.net>]

Borislav Petkov writes:

> Hi,
> 
> On Thu, Jun 18, 2009 at 9:10 AM, Peter Feuerer<peter@piie.net> wrote:
>> Hi Andreas, Hi Boris,
>>
>> Andreas Mohr writes:
>>
>>>> o suspend stops and resume starts the kernelmode in a clean way
>>>
>>> Didn't someone argue that pre_suspend_kernelmode was unnecessary?
>>> It's still in there. (could be submitted together with the
>>> Kconfig ACPI depends ;)
>>
>> Actually I think pre_suspend_kernelmode is needed, so it won't be dropped.
> 
> and it is needed, because...?

It's needed because we do now a clean revert to bios mode before we suspend. 
And after resume we have to switch to kernelmode again, if the driver 
was in kernelmode before suspend. So we need to keep track of in what state 
the driver was before suspending. That's what's this variable is for.

>> I'll add the ACPI dependency to Kconfig and submit the patch to lkml
>> and directly to Linus, as Len doesn't seem to react?! - Boris what do
>> you think? I mean, even if there's a problem with suspend / resume,
>> this can also be fixed after the merge window, while all those release
>> candidates are done.
> 
> Nope, this has to be fixed before submission. The merge window is open,
> I think, until mid next week so there's plenty of time.

I'll be only there until Sunday evening. I'm going to be on business trip 
starting on Monday (and returning probably at Saturday). But I'll do my best 
to figure out the problem.

I wasn't able to reproduce the suspend / resume problem Andreas has 
with acerhdf 0.5.9 yesterday and the day before. Do you also have the 
problem, that acerhdf is reading sometimes an unexpected Fan state after 
resuming?

kind regards,
--peter