Re: [PATCH] Acer Aspire One fan control, simplified and scrubbed

[Peter Feuerer <peter@piie.net>]

Hi,

Borislav Petkov writes:

> Hi,
> 
> On Sat, Jun 20, 2009 at 08:38:46PM +0200, Peter Feuerer wrote:
>> You removed the feature of controlling the fan from userspace, while the
>> driver is running in kernelmode=off!
>> ( echo 0 > /sys/class/thermal/thermal_zone0/cdev0/cur_state calls also the
>> acerhdf_set_cur_state function )
> 
> I still don't really see the need for this since the module is doing
> pretty good job already. Besides, its not like there is really a need
> for userspace daemon doing heavy calculations and based on those
> controlls the fan - simply turning it on and off based on the current
> temp readings is what is needed and the thermal layer does that just
> fine already :).

Ok, we'll leave this feature out, as the code is really much cleaner and I 
also doubt that anybody will miss it.

> 
>> --
>> 
>> Acerhdf is a driver for Acer Aspire One netbooks. It allows
>> to access the temperature sensor and to control the fan.
>> 
>> Peter:
>> 
>>  - fixed bios table terminator Version string ( 0 to "" )
>>  - added acerhdf_enable_kernelmode
>>  - modified acerhdf_revert_to_bios_mode to disable polling
>>  - modified acerhdf_get_temp to omit the pr_notice (temperature
>>    should not be printed out in verbose mode, when called from
>>    acerhdf_set_cur_state)
> 
> see below for some minor nitpicking.

I'll fix the things you suggested and send then a (hopefully) last acerhdf 
patch to lkml and linus, ok?

Again, thank you very much! I've really learned a lot from you!

regards,
--peter