From: hpa@zytor.com (H. Peter Anvin)
To: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Cyrix MII cpuid returns stale %ecx
Date: Fri, 3 Dec 2004 22:18:12 +0000 (UTC) [thread overview]
Message-ID: <coqon4$p9e$1@terminus.zytor.com> (raw)
In-Reply-To: 20041203090843.GA25528@wotan.suse.de
Followup to: <20041203090843.GA25528@wotan.suse.de>
By author: Andi Kleen <ak@suse.de>
In newsgroup: linux.dev.kernel
>
> On Tue, Nov 30, 2004 at 10:07:55PM -0700, Zwane Mwaikambo wrote:
> > This patch is for the following bug, thanks to Ondrej Zary for
> > reporting, testing and submitting a patch.
> >
> > http://bugzilla.kernel.org/show_bug.cgi?id=3767
> >
> > It appears that the Cyrix MII won't touch %ecx at all resulting in stale
> > data being returned as extended attributes, so clear ecx before issuing
> > the cpuid. I have also made the capability print code display all the
> > capability words for easier debugging in future.
>
> Can you please change cpuid() on x86-64 too?
>
> I think it would be also better to not printk the capabilities
> at all or only with a special kernel option. Normally they are
> not needed, but they clutter up the boot log.
>
Since this is a bug fix for Cyrix MII, which isn't x86-64, it seems
pointless to do it for x86-64.
-hpa
prev parent reply other threads:[~2004-12-03 22:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-01 5:07 [PATCH] Cyrix MII cpuid returns stale %ecx Zwane Mwaikambo
2004-12-03 9:08 ` Andi Kleen
2004-12-03 16:57 ` Zwane Mwaikambo
2004-12-03 22:18 ` H. Peter Anvin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='coqon4$p9e$1@terminus.zytor.com' \
--to=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox