From: filia@softhome.net
To: viro@parcelfarce.linux.theplanet.co.uk, arjanv@redhat.com
Cc: linux-kernel@vger.kernel.org
Subject: Re: f_ops flag to speed up compatible ioctls in linux kernel
Date: Wed, 01 Sep 2004 03:50:11 -0600 [thread overview]
Message-ID: <courier.41359B53.00007549@softhome.net> (raw)
Hi!
Stop being arrogant.
Can you please elaborate on how to make Linux kernel support e.g. motion
controllers? They do not fit *any* known to me driver interface. They have
several axes, they have about twenty parameters (float or integer), and they
have several commands, a-la start, graceful stop, abrupt stop. Plus
obviously diagnostics - about ten another commands with absolutely different
parameters. And about ten motion monitoring commands. And this is one
example I were need to program.
Or take any other freaky device we might got on market tomorrow.
As ioctl() opponent, be kind and give some advice what to do in that kind
of situations.
Al Viro written:
>> Hello!
>> Currently, on the x86_64 architecture, its quite tricky to make
>> a char device ioctl work for an x86 executables.
>> In particular,
>> 1. there is a requirement that ioctl number is unique -
>> which is hard to guarantee especially for out of kernel modules
>
>Too bad.
>
>> 2. there's a performance huge overhead for each compat call - there's
>> a hash lookup in a global hash inside a lock_kernel -
>> and I think compat performance *is* important.
>>
>> Further, adding a command to the ioctl suddenly requires changing
>> two places - registration code and ioctl itself.
>
> So don't add them. Adding a new ioctl is *NOT* a step to be taken lightly -
> we used to be far too accepting in that area and as somebody who'd waded
> through the resulting dungpiles over the last months I can tell you that
> result is utterly revolting.
>
> Excuse me, but I have zero sympathy to people who complain about obstacles
> to dumping more into the same piles - it should be hard.
Arjan van de Ven written:
>> Further, adding a command to the ioctl suddenly requires changing
>> two places - registration code and ioctl itself.
>
>adding ioctls SHOULD be painful. Really painful. It's similar to adding
>syscalls; you'll have to keep compatibility basically forever so adding
>should not be an easy thing.
--- with respect. best regards.
*** Philips @ Saarbruecken.
next reply other threads:[~2004-09-01 9:50 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-01 9:50 filia [this message]
2004-09-01 9:52 ` f_ops flag to speed up compatible ioctls in linux kernel Arjan van de Ven
2004-09-01 10:16 ` filia
[not found] ` <4135B9FC.7050602@hist.no>
2004-09-01 13:29 ` Ihar 'Philips' Filipau
2004-09-01 15:28 ` Ihar 'Philips' Filipau
2004-09-02 7:29 ` Helge Hafting
2004-09-01 13:43 ` Olivier Galibert
-- strict thread matches above, loose matches on Subject: below --
2004-12-27 22:22 Michael S. Tsirkin
2004-09-01 15:40 Albert Cahalan
2004-09-01 21:23 ` Michael S. Tsirkin
2004-09-01 21:38 ` Lee Revell
2004-09-01 21:43 ` Chris Wright
2004-09-01 21:44 ` Roland Dreier
2004-09-01 15:36 Albert Cahalan
2004-09-01 15:59 ` Roland Dreier
2004-09-01 21:53 ` Michael S. Tsirkin
2004-09-01 22:58 ` Roland Dreier
2004-09-01 23:18 ` Michael S. Tsirkin
2004-09-01 7:22 Michael S. Tsirkin
2004-09-01 7:32 ` viro
2004-09-01 7:44 ` Michael S. Tsirkin
2004-09-01 7:47 ` Lee Revell
2004-09-01 8:19 ` Michael S. Tsirkin
2004-09-01 15:55 ` Roland Dreier
2004-09-01 18:02 ` Chris Wright
2004-09-01 18:12 ` Roland Dreier
2004-09-01 18:31 ` viro
2004-09-01 20:54 ` Roland Dreier
[not found] ` <20040901170800.K1924@build.pdx.osdl.net>
[not found] ` <20040901190122.L1924@build.pdx.osdl.net>
2004-09-02 3:46 ` Roland Dreier
2004-09-01 18:06 ` Bill Davidsen
2004-09-01 8:30 ` Arjan van de Ven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=courier.41359B53.00007549@softhome.net \
--to=filia@softhome.net \
--cc=arjanv@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@parcelfarce.linux.theplanet.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox