From: filia@softhome.net
To: Arjan van de Ven <arjanv@redhat.com>
Cc: viro@parcelfarce.linux.theplanet.co.uk, linux-kernel@vger.kernel.org
Subject: Re: f_ops flag to speed up compatible ioctls in linux kernel
Date: Wed, 01 Sep 2004 04:16:59 -0600 [thread overview]
Message-ID: <courier.4135A19B.00007EA5@softhome.net> (raw)
In-Reply-To: <20040901095229.GA11908@devserv.devel.redhat.com>
Arjan van de Ven writes:
> On Wed, Sep 01, 2004 at 03:50:11AM -0600, filia@softhome.net wrote:
>> Hi!
>>
>> Stop being arrogant.
>> Can you please elaborate on how to make Linux kernel support e.g. motion
>> controllers? They do not fit *any* known to me driver interface. They have
>> several axes, they have about twenty parameters (float or integer), and
>
> parameters nicely fit in sysfs.
>
What about errors?
"set di 200000" might fail for lots of reasons.
>> they have several commands, a-la start, graceful stop, abrupt stop. Plus
>> obviously diagnostics - about ten another commands with absolutely
>> different parameters. And about ten motion monitoring commands. And this is
>> one example I were need to program.
>
> a write() interface doesn't work???
> Hard to believe, you even call them commands.
> fd = open("/dev/funkydevice");
> write(fd, "start");
>
> doesn't sound insane to me
>
it doesn't, since you didn't tryed to make error handling. every thing can
fail - this is control of mechanics - and it fails often and for a lot of
reasons. Put here error handling (write(struct whatever) has to return
another struct whatever2 filled with error description) and thread-safeness.
Pluss some controllers do support multi-dimensional movements "start
x,y,z,etc" - and you might have _several_ error structs. Atomicity is
important for multi-dimensional moves too - move on given axes starts with
single command.
hu?
I do not see much point in renaming ioctl() to write() all over the place -
at least when people see ioctl() they understand that it is not standard
functionality. write() will for sure confuse a lot of people.
--- with respect. best regards.
*** Philips @ Saarbruecken.
next prev parent reply other threads:[~2004-09-01 10:17 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-01 9:50 f_ops flag to speed up compatible ioctls in linux kernel filia
2004-09-01 9:52 ` Arjan van de Ven
2004-09-01 10:16 ` filia [this message]
[not found] ` <4135B9FC.7050602@hist.no>
2004-09-01 13:29 ` Ihar 'Philips' Filipau
2004-09-01 15:28 ` Ihar 'Philips' Filipau
2004-09-02 7:29 ` Helge Hafting
2004-09-01 13:43 ` Olivier Galibert
-- strict thread matches above, loose matches on Subject: below --
2004-12-27 22:22 Michael S. Tsirkin
2004-09-01 15:40 Albert Cahalan
2004-09-01 21:23 ` Michael S. Tsirkin
2004-09-01 21:38 ` Lee Revell
2004-09-01 21:43 ` Chris Wright
2004-09-01 21:44 ` Roland Dreier
2004-09-01 15:36 Albert Cahalan
2004-09-01 15:59 ` Roland Dreier
2004-09-01 21:53 ` Michael S. Tsirkin
2004-09-01 22:58 ` Roland Dreier
2004-09-01 23:18 ` Michael S. Tsirkin
2004-09-01 7:22 Michael S. Tsirkin
2004-09-01 7:32 ` viro
2004-09-01 7:44 ` Michael S. Tsirkin
2004-09-01 7:47 ` Lee Revell
2004-09-01 8:19 ` Michael S. Tsirkin
2004-09-01 15:55 ` Roland Dreier
2004-09-01 18:02 ` Chris Wright
2004-09-01 18:12 ` Roland Dreier
2004-09-01 18:31 ` viro
2004-09-01 20:54 ` Roland Dreier
[not found] ` <20040901170800.K1924@build.pdx.osdl.net>
[not found] ` <20040901190122.L1924@build.pdx.osdl.net>
2004-09-02 3:46 ` Roland Dreier
2004-09-01 18:06 ` Bill Davidsen
2004-09-01 8:30 ` Arjan van de Ven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=courier.4135A19B.00007EA5@softhome.net \
--to=filia@softhome.net \
--cc=arjanv@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@parcelfarce.linux.theplanet.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox