Re: [PATCH 5/6] syscalls: add define syscall prefix macro

Arnd Bergmann
2010-02-08T20:48:31Z

On Monday 08 February 2010 18:54:07 Christoph Hellwig wrote:
> On Mon, Feb 08, 2010 at 05:12:36PM +0100, Arnd Bergmann wrote:
> > On Monday 08 February 2010, Jason Baron wrote:
> > > So I was trying to keep the names of the arch ia32 compat sys calls the
> > > same, ie 'sys32_blah'. However, I agree a common naming scheme makes
> > > more sense. what about 'arch_compat_sys_blah'? So as to distinguish from
> > > the common compat syscalls 'compat_sys_blah'.
> >
> > Why do you need to distinguish them? I would hope that we never need to
> > have a kernel with both a generic and an arch specific compat version
> > of the same syscall.
>
> Well, the usual alignment or number of arguments issues could lead to
> just that. We should deal with it the same way as for native syscalls.

Ah, right. The arch specific syscall may just be a wrapper calling the
generic function, so we need them both.

Arnd