Re: [RFT/PATCH v2 4/6] x86-64: vclock_gettime(CLOCK_MONOTONIC) can't ever see nsec < 0

Andrew Lutomirski
2011-04-07T11:27:29Z

On Thu, Apr 7, 2011 at 3:57 AM, Ingo Molnar <mingo@elte.hu> wrote:
>
> * Andy Lutomirski <luto@MIT.EDU> wrote:
>
>> +
>> +     /* wall_time_nsec, vgetns(), and wall_to_monotonic.tv_nsec
>> +      * are all guaranteed to be nonnegative.
>> +      */
>
>> +     /* wall_time_nsec and wall_to_monotonic.tv_nsec are
>> +      * guaranteed to be between 0 and NSEC_PER_SEC.
>> +      */
>
> Nor have you addressed stylistic review feedback i gave before ...
>
> Really, we absolutely must insist on 110% attention to small details for
> patches that modify assembly code.

Crud, I fixed most of those. I'll get these in v3. (I assume you're
talking about comment style.)

--Andy

>
> Thanks,
>
>        Ingo
>