From: Ben Gardiner <bengardiner@nanometrics.ca>
To: Liam Girdwood <lrg@slimlogic.co.uk>, alsa-devel@alsa-project.org
Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.de>,
Sekhar Nori <nsekhar@ti.com>,
davinci-linux-open-source@linux.davincidsp.com,
James Nuss <jamesnuss@nanometrics.ca>,
linux-kernel@vger.kernel.org
Subject: [PATCH 0/4] davinci-mcasp: fix tdm_slots and CBM/CFS
Date: Thu, 21 Apr 2011 14:19:00 -0400 [thread overview]
Message-ID: <cover.1303408522.git.bengardiner@nanometrics.ca> (raw)
This patch series is comprised of three bugfixes and one cleanup that
were performed during prototyping of McASP operation in codec clock-
master frame-slave mode.
First we noticed that the check of the number of tdm slots requested
by platform data was always returning true -- unrelated to CMB/CFS
mode.
Then a cleanup: the PDIR values set are currently based on magic
numbers and there are available bitfield definitions. Not strictly
needed but it makes the changes introduced in the last patch simpler
to read.
It was found that the hardware parameters assigned when
codec clock-master frame-slave is requested were incorrect. This
change is required for correct CBM/CFS operation.
Finally, the direction of the pins is corrected to reflect the
implications of codec clock-master frame-slave -- i.e. mcasp clock-
input frame-output. This change is also required for correct operation.
The combination was tested with a logic analyzer and the hrtimer pwm
device from Bill Gatliff's PWM framework [1] on a da850evm with
hardware modifications to access the McASP lines.
[1] http://article.gmane.org/gmane.linux.kernel.embedded/3486/
Ben Gardiner (4):
davinci-mcasp: correct tdm_slots limit
davinci-mcasp: use bitfield definitions for PDIR
davinci-mcasp: fix _CBM_CFS hw_params
davinci-mcasp: fix _CBM_CFS pin directions
sound/soc/davinci/davinci-mcasp.c | 19 ++++++++++++-------
1 files changed, 12 insertions(+), 7 deletions(-)
next reply other threads:[~2011-04-21 18:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-21 18:19 Ben Gardiner [this message]
2011-04-21 18:19 ` [PATCH 1/4] davinci-mcasp: correct tdm_slots limit Ben Gardiner
2011-04-26 10:46 ` Mark Brown
2011-04-26 13:20 ` Ben Gardiner
2011-04-21 18:19 ` [PATCH 2/4] davinci-mcasp: use bitfield definitions for PDIR Ben Gardiner
2011-04-21 18:19 ` [PATCH 3/4] davinci-mcasp: fix _CBM_CFS hw_params Ben Gardiner
2011-04-21 18:19 ` [PATCH 4/4] davinci-mcasp: fix _CBM_CFS pin directions Ben Gardiner
2011-04-26 8:16 ` [PATCH 0/4] davinci-mcasp: fix tdm_slots and CBM/CFS Liam Girdwood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1303408522.git.bengardiner@nanometrics.ca \
--to=bengardiner@nanometrics.ca \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=davinci-linux-open-source@linux.davincidsp.com \
--cc=jamesnuss@nanometrics.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
--cc=nsekhar@ti.com \
--cc=perex@perex.cz \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).