Re: [PATCH V3 2/4] drivers/i2c/busses/i2c-at91.c: add new driver

Russell King - ARM Linux
2011-11-09T19:12:05Z

On Wed, Nov 09, 2011 at 05:01:07PM +0100, Voss, Nikolaus wrote:
> Hi Ryan,
> >
> > > + dev->irq = irq->start;
> > > + platform_set_drvdata(pdev, dev);
> > > +
> > > + dev->clk = clk_get(&pdev->dev, "twi_clk");
> >
> >
> > This didn't get answered. Can't you just do:
> >
> > dev->clk = clk_get(&pdev->dev, NULL);
> >
> > and clkdev should figure out the correct clock based on the device pointer?
>
> No, this doesn't work on at91 since the clocks have no dev_id property
> but only con_id. I cannot see a reason for this, but that's the way it's
> done. Multiple hardware interfaces are handled via a lookup table.

If you can, you could move over to doing this via the standard method
and start switching some of this stuff over to using dev_id.

We'll then have another platform starting to use this stuff correctly.