From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756798Ab1KIWJo (ORCPT ); Wed, 9 Nov 2011 17:09:44 -0500 Received: from smtp-out.google.com ([216.239.44.51]:37981 "EHLO smtp-out.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932089Ab1KIWJn (ORCPT ); Wed, 9 Nov 2011 17:09:43 -0500 DomainKey-Signature: a=rsa-sha1; s=beta; d=google.com; c=nofws; q=dns; h=from:to:cc:subject:date:message-id:x-mailer:organization:x-system-of-record; b=RhYyPNTA89lrv4Gy+4iDa/pcreeMH39p7raEPqR16/zO74a7GFRtRVaBl7Z05L2HG wP6LwBNqxtA4GJWJcK2MA== From: David Decotigny To: netdev@vger.kernel.org, linux-kernel@vger.kernel.org Cc: "David S. Miller" , Ian Campbell , Eric Dumazet , Jeff Kirsher , Ben Hutchings , David Decotigny Subject: [PATCH net-next v1 0/9] forcedeth: stats & debug enhancements Date: Wed, 9 Nov 2011 14:09:14 -0800 Message-Id: X-Mailer: git-send-email 1.7.3.1 Organization: Google, Inc. X-System-Of-Record: true Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org These changes implement the ndo_get_stats64 API and add a few more stats and debugging features for forcedeth. They also ensure that stats updates are correct in SMP systems, 32 or 64-bits. Regarding the "implement ndo_get_stats64() API" patch, I'm not sure I'm using the right way to protect the 64b stats. Ideally, I would like them to be non-blocking (u64_stats_sync.h), but as there are several sources for updates, I don't think I can do without locking or per-CPU stats. Would per-CPU stats be better here (note: I expect the contention on netdev_priv(dev)->stats_lock to be _VERY_ low)? Tested: ~150Mbps incoming TCP, ethtool -S in a loop, x86_64 16-way: tx_bytes: 1413863329 rx_packets: 38918872 tx_packets: 19828148 rx_bytes: 57818685991 ############################################ # Patch Set Summary: David Decotigny (6): forcedeth: expose module parameters in /sys/module forcedeth: stats for rx_packets based on hardware registers forcedeth: implement ndo_get_stats64() API forcedeth: account for dropped RX frames forcedeth: stats updated with a deferrable timer forcedeth: whitespace/indentation fixes Mike Ditto (1): forcedeth: Add messages to indicate using MSI or MSI-X Sameer Nanda (2): forcedeth: allow to silence "TX timeout" debug messages forcedeth: new ethtool stat counter for TX timeouts drivers/net/ethernet/nvidia/forcedeth.c | 271 +++++++++++++++++++++---------- 1 files changed, 184 insertions(+), 87 deletions(-) -- 1.7.3.1