From: "Miguel Gómez" <magomez@igalia.com>
To: arnaud.patard@rtp-net.org, gregkh@linuxfoundation.org,
aaro.koskinen@iki.fi, dan.carpenter@oracle.com
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
"Miguel Gómez" <magomez@igalia.com>
Subject: [PATCH 00/19 v2] Several cleanings and style fixes
Date: Fri, 6 Jul 2012 12:40:35 +0200 [thread overview]
Message-ID: <cover.1341569486.git.magomez@igalia.com> (raw)
In-Reply-To: <cover.1341498465.git.magomez@igalia.com>
Hi!
Second version of the patches round containing suggestions made
to the first version:
* patch 0001:
** keep some useful comments.
** format a couple of multiline comments
** don't remove empty lines in vb_util.h and vb_init.h
* patch 0005:
** remove exclamation marks from a string
* patch 0015
** simplify a bit more by joining another couple of conditions
* patch 0017
** replace do-while with gotos
* patch 0018
** move some comments to previous line instead of modifying them
Also, I'm sending all of the patches again because they were encoded in
base64 instead of 8bit.
Regards!
Miguel Gómez (19):
Staging: xgifb: Comment cleaning.
Staging: xgifb: Remove unneeded XGI_LCD_TYPE enumeration.
Staging: xgifb: Remove LCDA detection in xgifb_probe().
Staging: xgifb: Remove unused struct _chswtable.
Staging: xgifb: Improve debug strings.
Staging: xgifb: Remove useless switch in XGIfb_detect_VB().
Staging: xgifb: Simplify XGIfb_GetXG21DefaultLVDSModeIdx().
Staging: xgifb: Remove unneeded var and condition in
XGIfb_search_vesamode().
Staging: xgifb: Remove useless always true condition.
Staging: xgifb: Rework conditions in XGI_SetATTRegs().
Staging: xgifb: Refactor XGI_AjustCRT2Rate().
Staging: xgifb: Refactor XGI_GetVBType().
Staging: xgifb: Rework conditions in XGI_GetVBInfo().
Staging: xgifb: Refactor XGI_GetCRT2ResInfo().
Staging: xgifb: Rework conditions in XGI_SetLockRegs().
Staging: xgifb: Rework conditions in XGI_EnableBridge().
Staging: xgifb: Rework some conditions in XGI_SetCRT2ModeRegs().
Staging: xgifb: Fix coding style.
Staging: xgifb: Remove useless condition.
drivers/staging/xgifb/XGI_main.h | 14 -
drivers/staging/xgifb/XGI_main_26.c | 247 +++---------
drivers/staging/xgifb/XGIfb.h | 8 +-
drivers/staging/xgifb/vb_def.h | 3 -
drivers/staging/xgifb/vb_init.c | 166 +-------
drivers/staging/xgifb/vb_setmode.c | 747 ++++++++++++++++-------------------
drivers/staging/xgifb/vb_struct.h | 3 -
drivers/staging/xgifb/vb_table.h | 65 ++-
drivers/staging/xgifb/vgatypes.h | 34 --
9 files changed, 455 insertions(+), 832 deletions(-)
--
1.7.9.5
next prev parent reply other threads:[~2012-07-06 10:41 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-05 14:45 [PATCH 00/19] Several cleanings and style fixes Miguel Gómez
2012-07-05 14:45 ` [PATCH 01/19] Staging: xgifb: Comment cleaning Miguel Gómez
2012-07-05 17:24 ` Aaro Koskinen
2012-07-06 8:00 ` Miguel Gómez
2012-07-05 17:35 ` Joe Perches
2012-07-06 8:02 ` Miguel Gómez
2012-07-05 20:35 ` Dan Carpenter
2012-07-06 8:14 ` Miguel Gómez
2012-07-05 14:45 ` [PATCH 02/19] Staging: xgifb: Remove unneeded XGI_LCD_TYPE enumeration Miguel Gómez
2012-07-05 14:45 ` [PATCH 03/19] Staging: xgifb: Remove LCDA detection in xgifb_probe() Miguel Gómez
2012-07-05 14:45 ` [PATCH 04/19] Staging: xgifb: Remove unused struct _chswtable Miguel Gómez
2012-07-05 14:45 ` [PATCH 05/19] Staging: xgifb: Improve debug strings Miguel Gómez
2012-07-05 17:42 ` Aaro Koskinen
2012-07-06 8:09 ` Miguel Gómez
2012-07-05 14:45 ` [PATCH 06/19] Staging: xgifb: Remove useless switch in XGIfb_detect_VB() Miguel Gómez
2012-07-05 14:45 ` [PATCH 07/19] Staging: xgifb: Simplify XGIfb_GetXG21DefaultLVDSModeIdx() Miguel Gómez
2012-07-05 14:45 ` [PATCH 08/19] Staging: xgifb: Remove unneeded var and condition in XGIfb_search_vesamode() Miguel Gómez
2012-07-05 14:45 ` [PATCH 09/19] Staging: xgifb: Remove useless always true condition Miguel Gómez
2012-07-05 14:45 ` [PATCH 10/19] Staging: xgifb: Rework conditions in XGI_SetATTRegs() Miguel Gómez
2012-07-05 14:45 ` [PATCH 11/19] Staging: xgifb: Refactor XGI_AjustCRT2Rate() Miguel Gómez
2012-07-05 14:45 ` [PATCH 12/19] Staging: xgifb: Refactor XGI_GetVBType() Miguel Gómez
2012-07-05 14:45 ` [PATCH 13/19] Staging: xgifb: Rework conditions in XGI_GetVBInfo() Miguel Gómez
2012-07-05 14:45 ` [PATCH 14/19] Staging: xgifb: Refactor XGI_GetCRT2ResInfo() Miguel Gómez
2012-07-05 14:45 ` [PATCH 15/19] Staging: xgifb: Rework conditions in XGI_SetLockRegs() Miguel Gómez
2012-07-05 18:00 ` Aaro Koskinen
2012-07-06 8:12 ` Miguel Gómez
2012-07-06 6:51 ` Dan Carpenter
2012-07-06 9:04 ` Miguel Gómez
2012-07-06 10:27 ` Dan Carpenter
2012-07-05 14:45 ` [PATCH 16/19] Staging: xgifb: Rework conditions in XGI_EnableBridge() Miguel Gómez
2012-07-05 14:46 ` [PATCH 17/19] Staging: xgifb: Rework some conditions in XGI_SetCRT2ModeRegs() Miguel Gómez
2012-07-05 14:46 ` [PATCH 18/19] Staging: xgifb: Fix coding style Miguel Gómez
2012-07-05 14:46 ` [PATCH 19/19] Staging: xgifb: Remove useless condition Miguel Gómez
2012-07-06 10:40 ` Miguel Gómez [this message]
2012-07-06 10:40 ` [PATCH 01/19 v2] Staging: xgifb: Comment cleaning Miguel Gómez
2012-07-06 10:40 ` [PATCH 02/19 v2] Staging: xgifb: Remove unneeded XGI_LCD_TYPE enumeration Miguel Gómez
2012-07-06 10:40 ` [PATCH 03/19 v2] Staging: xgifb: Remove LCDA detection in xgifb_probe() Miguel Gómez
2012-07-09 18:39 ` Greg KH
2012-07-09 22:08 ` Aaro Koskinen
2012-07-13 14:02 ` Miguel Gómez
2012-07-06 10:40 ` [PATCH 04/19 v2] Staging: xgifb: Remove unused struct _chswtable Miguel Gómez
2012-07-06 10:40 ` [PATCH 05/19 v2] Staging: xgifb: Improve debug strings Miguel Gómez
2012-07-06 10:40 ` [PATCH 06/19 v2] Staging: xgifb: Remove useless switch in XGIfb_detect_VB() Miguel Gómez
2012-07-06 10:40 ` [PATCH 07/19 v2] Staging: xgifb: Simplify XGIfb_GetXG21DefaultLVDSModeIdx() Miguel Gómez
2012-07-06 10:40 ` [PATCH 08/19 v2] Staging: xgifb: Remove unneeded var and condition in XGIfb_search_vesamode() Miguel Gómez
2012-07-06 10:40 ` [PATCH 09/19 v2] Staging: xgifb: Remove useless always true condition Miguel Gómez
2012-07-06 10:40 ` [PATCH 10/19 v2] Staging: xgifb: Rework conditions in XGI_SetATTRegs() Miguel Gómez
2012-07-06 10:40 ` [PATCH 11/19 v2] Staging: xgifb: Refactor XGI_AjustCRT2Rate() Miguel Gómez
2012-07-06 10:40 ` [PATCH 12/19 v2] Staging: xgifb: Refactor XGI_GetVBType() Miguel Gómez
2012-07-06 10:40 ` [PATCH 13/19 v2] Staging: xgifb: Rework conditions in XGI_GetVBInfo() Miguel Gómez
2012-07-06 10:40 ` [PATCH 14/19 v2] Staging: xgifb: Refactor XGI_GetCRT2ResInfo() Miguel Gómez
2012-07-06 10:40 ` [PATCH 15/19 v2] Staging: xgifb: Rework conditions in XGI_SetLockRegs() Miguel Gómez
2012-07-06 10:40 ` [PATCH 16/19 v2] Staging: xgifb: Rework conditions in XGI_EnableBridge() Miguel Gómez
2012-07-06 10:40 ` [PATCH 17/19 v2] Staging: xgifb: Rework some conditions in XGI_SetCRT2ModeRegs() Miguel Gómez
2012-07-06 10:40 ` [PATCH 18/19 v2] Staging: xgifb: Fix coding style Miguel Gómez
2012-07-06 10:40 ` [PATCH 19/19 v2] Staging: xgifb: Remove useless condition Miguel Gómez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1341569486.git.magomez@igalia.com \
--to=magomez@igalia.com \
--cc=aaro.koskinen@iki.fi \
--cc=arnaud.patard@rtp-net.org \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox