public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Mauro Carvalho Chehab <mchehab@redhat.com>
To: unlisted-recipients:; (no To-header on input)
Cc: Mauro Carvalho Chehab <mchehab@redhat.com>,
	Linux Edac Mailing List <linux-edac@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	"Arvind R ." <arvino55@gmail.com>
Subject: [PATCH EDAC 0/3] Fix i82975x_edac driver
Date: Tue, 16 Oct 2012 23:41:07 -0300	[thread overview]
Message-ID: <cover.1350440633.git.mchehab@redhat.com> (raw)

The i82975x_edac driver is completely broken. I got a bug report
related to an OOPS caused by the recent changes there

After fixing it, I noticed weird behaviours at the driver on my
test machine, especially after enabling the EDAC debug logic.

In the end, the entire logic there that fills memory data were
broken, and also, the error report logic.

The worse bug there, IMHO, is that, during Corrected Errors,
it will only report the right DIMM in 50% of the cases, on
the more standard memory configuration (Dual channel, interleaved).

That happens because the logic were checking for bit 1, instead of
bit 6, in order to decide if the error belongs to channel A or to
channel B.

The patches on this series are:

	- patch 1: fixes the reported OOPS - it is a good candidate
for Kernel 3.7 and -stable;

	- patch 2: convert the already existing debug code
to use the standard way for debug (instead of requiring someone
to edit the source code to uncomment the debug macro);
So, the third patch on this series;

	- patch 3: rewrite the entire fill/report logic.

Patches got tested on a Dell Precision N390 and worked as expected.

Regards,
Mauro

Mauro Carvalho Chehab (3):
  i82975x_edac: Fix dimm label initialization
  i82975x_edac: Use the edac standard debug macro
  i82975x_edac: rewrite the entire fill/report logic

 drivers/edac/i82975x_edac.c | 457 ++++++++++++++++++++++++++------------------
 1 file changed, 272 insertions(+), 185 deletions(-)

-- 
1.7.11.7


             reply	other threads:[~2012-10-17  2:41 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-17  2:41 Mauro Carvalho Chehab [this message]
2012-10-17  2:41 ` [PATCH EDAC 1/3] i82975x_edac: Fix dimm label initialization Mauro Carvalho Chehab
2012-10-17  2:41 ` [PATCH EDAC 2/3] i82975x_edac: Use the edac standard debug macro Mauro Carvalho Chehab
2012-10-17  2:41 ` [PATCH EDAC 3/3] i82975x_edac: rewrite the entire fill/report logic Mauro Carvalho Chehab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1350440633.git.mchehab@redhat.com \
    --to=mchehab@redhat.com \
    --cc=arvino55@gmail.com \
    --cc=linux-edac@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox