From: Tim Chen <tim.c.chen@linux.intel.com>
To: Herbert Xu <herbert@gondor.hengli.com.au>,
"H. Peter Anvin" <hpa@zytor.com>,
"David S. Miller" <davem@davemloft.net>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: Tim Chen <tim.c.chen@linux.intel.com>,
Matthew Wilcox <willy@linux.intel.com>,
Jim Kukunas <james.t.kukunas@linux.intel.com>,
Keith Busch <keith.busch@intel.com>,
Erdinc Ozturk <erdinc.ozturk@intel.com>,
Vinodh Gopal <vinodh.gopal@intel.com>,
James Guilford <james.guilford@intel.com>,
Wajdi Feghali <wajdi.k.feghali@intel.com>,
Jussi Kivilinna <jussi.kivilinna@iki.fi>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-crypto@vger.kernel.org, linux-scsi@vger.kernel.org
Subject: [PATCH v3 0/4] Patchset to use PCLMULQDQ to accelerate CRC-T10DIF checksum computation
Date: Wed, 1 May 2013 12:52:47 -0700 [thread overview]
Message-ID: <cover.1367436101.git.tim.c.chen@linux.intel.com> (raw)
Currently the CRC-T10DIF checksum is computed using a generic table lookup
algorithm. By switching the checksum to PCLMULQDQ based computation,
we can speedup the computation by 8x for checksumming 512 bytes and
even more for larger buffer size. This will improve performance of SCSI
drivers turning on the CRC-T10IDF checksum. In our SSD based experiments,
we have seen increase disk throughput by 3.5x with T10DIF for 512 byte
block size.
This patch set provides the x86_64 routine using PCLMULQDQ instruction
and switches the crc_t10dif library function to use the faster PCLMULQDQ
based routine when available.
Tim
v3
1. Update the crct10dif crypto transform used in the crct10dif library in a safe way.
2. Load the accelerated t10dif transform for the x86_64 cpus that support it.
3. Added generic crct10dif crypto transform.
v2
1. Get rid of unnecessary xmm registers save and restore and fix ENDPROC
position in PCLMULQDQ version of crc t10dif computation.
2. Fix URL to paper reference of CRC computation with PCLMULQDQ.
3. Add one additional tcrypt test case to exercise more code paths through
crc t10dif computation.
4. Fix config dependencies of CRYPTO_CRCT10DIF.
Thanks to Herbert Xu, Matthew Wilcox and Jussi Kivilinna who reviewed the patches and
Keith Busch for testing version 1 of the patch set.
Tim Chen (4):
Wrap crc_t10dif function all to use crypto transform framework
Accelerated CRC T10 DIF computation with PCLMULQDQ instruction
Glue code to cast accelerated CRCT10DIF assembly as a crypto
transform
Simple correctness and speed test for CRCT10DIF hash
arch/x86/crypto/Makefile | 2 +
arch/x86/crypto/crct10dif-pcl-asm_64.S | 643 ++++++++++++++++++++++++++++++++
arch/x86/crypto/crct10dif-pclmul_glue.c | 157 ++++++++
crypto/Kconfig | 20 +
crypto/Makefile | 1 +
crypto/crct10dif.c | 126 +++++++
crypto/tcrypt.c | 8 +
crypto/testmgr.c | 10 +
crypto/testmgr.h | 33 ++
include/linux/crc-t10dif.h | 5 +
lib/crc-t10dif.c | 95 ++++-
11 files changed, 1098 insertions(+), 2 deletions(-)
create mode 100644 arch/x86/crypto/crct10dif-pcl-asm_64.S
create mode 100644 arch/x86/crypto/crct10dif-pclmul_glue.c
create mode 100644 crypto/crct10dif.c
--
1.7.11.7
next reply other threads:[~2013-05-02 2:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-01 19:52 Tim Chen [this message]
2013-05-01 19:52 ` [PATCH v3 1/4] Wrap crc_t10dif function all to use crypto transform framework Tim Chen
2013-05-01 19:52 ` [PATCH v3 2/4] Accelerated CRC T10 DIF computation with PCLMULQDQ instruction Tim Chen
2013-05-01 19:52 ` [PATCH v3 3/4] Glue code to cast accelerated CRCT10DIF assembly as a crypto transform Tim Chen
2013-05-01 19:52 ` [PATCH v3 4/4] Simple correctness and speed test for CRCT10DIF hash Tim Chen
2013-05-07 1:12 ` [PATCH v3 0/4] Patchset to use PCLMULQDQ to accelerate CRC-T10DIF checksum computation Tim Chen
2013-05-14 2:35 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1367436101.git.tim.c.chen@linux.intel.com \
--to=tim.c.chen@linux.intel.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=davem@davemloft.net \
--cc=erdinc.ozturk@intel.com \
--cc=herbert@gondor.hengli.com.au \
--cc=hpa@zytor.com \
--cc=james.guilford@intel.com \
--cc=james.t.kukunas@linux.intel.com \
--cc=jussi.kivilinna@iki.fi \
--cc=keith.busch@intel.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=vinodh.gopal@intel.com \
--cc=wajdi.k.feghali@intel.com \
--cc=willy@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox