Re: [PATCH 1/2] HID: Add driver for Holtek gaming mouse 04d9:a067

Andy Shevchenko
2013-05-28T16:06:53Z

On Tue, May 21, 2013 at 2:31 AM, Christian Ohm <chr.ohm@gmx.net> wrote:
> This mouse is sold as Sharkoon Drakonia and Perixx MX-2000 and reports a
> too high usage maximum and logical maximum. This driver fixes the report
> descriptor so those values don't exceed HID_MAX_USAGES.

Patch is already applied, but I think it worth to go through my
nitpicks as well.

> +++ b/drivers/hid/hid-holtek-mouse.c
> @@ -0,0 +1,72 @@
> +/*
> + * HID driver for Holtek gaming mice
> + * Copyright (c) 2013 Christian Ohm
> + * Heavily inspired by various other HID drivers that adjust the report
> + * descriptor.
> +*/
> +
> +/*

There is no need to break comments here.

> + * This program is free software; you can redistribute it and/or modify it
> + * under the terms of the GNU General Public License as published by the Free
> + * Software Foundation; either version 2 of the License, or (at your option)
> + * any later version.
> + */

> +module_exit(holtek_mouse_exit);
> +module_init(holtek_mouse_init);

module_hid_driver() instead.

--
With Best Regards,
Andy Shevchenko