public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH 0/2] staging: lustre: fix sparse warnings in lib-eq.c
@ 2014-05-07  6:21 Toby Smith
  2014-05-07  6:21 ` [PATCH 1/2] staging: lustre: fix sparse warning "should it be static" Toby Smith
  2014-05-07  6:21 ` [PATCH 2/2] staging: lustre: fix sparse warning "unexpected unlock" Toby Smith
  0 siblings, 2 replies; 3+ messages in thread
From: Toby Smith @ 2014-05-07  6:21 UTC (permalink / raw)
  To: Greg Kroah-Hartman, Peng Tao, Andreas Dilger
  Cc: devel, linux-kernel, Toby Smith

Fix warnings from sparse in lib-eq.c

Toby Smith (2):
  staging: lustre: fix sparse warning "should it be static"
  staging: lustre: fix sparse warning "unexpected unlock"

 drivers/staging/lustre/lnet/lnet/lib-eq.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

-- 
1.9.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH 1/2] staging: lustre: fix sparse warning "should it be static"
  2014-05-07  6:21 [PATCH 0/2] staging: lustre: fix sparse warnings in lib-eq.c Toby Smith
@ 2014-05-07  6:21 ` Toby Smith
  2014-05-07  6:21 ` [PATCH 2/2] staging: lustre: fix sparse warning "unexpected unlock" Toby Smith
  1 sibling, 0 replies; 3+ messages in thread
From: Toby Smith @ 2014-05-07  6:21 UTC (permalink / raw)
  To: Greg Kroah-Hartman, Peng Tao, Andreas Dilger
  Cc: devel, linux-kernel, Toby Smith

Fix the following warning in lib-eq.c
warning: symbol 'lnet_eq_dequeue_event' was not declared. Should it be static?

Signed-off-by: Toby Smith <toby@tismith.id.au>
---
 drivers/staging/lustre/lnet/lnet/lib-eq.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/lustre/lnet/lnet/lib-eq.c b/drivers/staging/lustre/lnet/lnet/lib-eq.c
index 7ce07f6..6e63c23 100644
--- a/drivers/staging/lustre/lnet/lnet/lib-eq.c
+++ b/drivers/staging/lustre/lnet/lnet/lib-eq.c
@@ -238,7 +238,7 @@ lnet_eq_enqueue_event(lnet_eq_t *eq, lnet_event_t *ev)
 	lnet_eq_wait_unlock();
 }
 
-int
+static int
 lnet_eq_dequeue_event(lnet_eq_t *eq, lnet_event_t *ev)
 {
 	int		new_index = eq->eq_deq_seq & (eq->eq_size - 1);
-- 
1.9.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH 2/2] staging: lustre: fix sparse warning "unexpected unlock"
  2014-05-07  6:21 [PATCH 0/2] staging: lustre: fix sparse warnings in lib-eq.c Toby Smith
  2014-05-07  6:21 ` [PATCH 1/2] staging: lustre: fix sparse warning "should it be static" Toby Smith
@ 2014-05-07  6:21 ` Toby Smith
  1 sibling, 0 replies; 3+ messages in thread
From: Toby Smith @ 2014-05-07  6:21 UTC (permalink / raw)
  To: Greg Kroah-Hartman, Peng Tao, Andreas Dilger
  Cc: devel, linux-kernel, Toby Smith

Fix the following warning in lib-eq.c
warning: context imbalance in 'lnet_eq_wait_locked' - unexpected unlock

Signed-off-by: Toby Smith <toby@tismith.id.au>
---
 drivers/staging/lustre/lnet/lnet/lib-eq.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/staging/lustre/lnet/lnet/lib-eq.c b/drivers/staging/lustre/lnet/lnet/lib-eq.c
index 6e63c23..d25dcd8 100644
--- a/drivers/staging/lustre/lnet/lnet/lib-eq.c
+++ b/drivers/staging/lustre/lnet/lnet/lib-eq.c
@@ -325,6 +325,7 @@ EXPORT_SYMBOL(LNetEQWait);
 
 static int
 lnet_eq_wait_locked(int *timeout_ms)
+__must_hold(&the_lnet.ln_eq_wait_lock)
 {
 	int		tms = *timeout_ms;
 	int		wait;
-- 
1.9.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2014-05-07  6:22 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-07  6:21 [PATCH 0/2] staging: lustre: fix sparse warnings in lib-eq.c Toby Smith
2014-05-07  6:21 ` [PATCH 1/2] staging: lustre: fix sparse warning "should it be static" Toby Smith
2014-05-07  6:21 ` [PATCH 2/2] staging: lustre: fix sparse warning "unexpected unlock" Toby Smith

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox