public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@intel.com>
To: linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org
Cc: Rusty Russell <rusty@rustcorp.com.au>,
	Jean Delvare <khali@linux-fr.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Li Zhong <zhong@linux.vnet.ibm.com>,
	Jon Mason <jon.mason@intel.com>,
	Daniel Vetter <daniel.vetter@ffwll.ch>,
	jani.nikula@intel.com
Subject: [PATCH 0/4] module: add support for unsafe, tainting parameters
Date: Mon, 11 Aug 2014 16:52:18 +0300	[thread overview]
Message-ID: <cover.1407764272.git.jani.nikula@intel.com> (raw)

This is a generic version of Daniel's patch [1] letting us have unsafe
module parameters (experimental, debugging, testing, etc.) that taint
the kernel when set. Quoting Daniel,

"""
Users just love to set random piles of options since surely enabling all
the experimental stuff helps. Later on we get bug reports because it all
fell apart.

Even more fun when it's labelled a regression when some change only just
made the feature possible (e.g. stolen memory fixes suddenly making fbc
possible).

Make it clear that users are playing with fire here.
"""

Patches 1-3 add the core functionality, patch 4 is our use case as an
example.

BR,
Jani.

[1] http://lkml.kernel.org/r/1394011994-30604-1-git-send-email-daniel.vetter@ffwll.ch


Jani Nikula (4):
  module: rename KERNEL_PARAM_FL_NOARG to avoid confusion
  module: make it possible to have unsafe, tainting module params
  module: add module_param_unsafe and module_param_named_unsafe
  drm/i915: taint the kernel if unsafe module parameters are set

 drivers/gpu/drm/i915/i915_params.c  |  8 ++---
 drivers/tty/serial/8250/8250_core.c |  2 +-
 include/linux/moduleparam.h         | 64 +++++++++++++++++++++++++++++++------
 kernel/module.c                     |  2 +-
 kernel/params.c                     | 17 ++++++++--
 security/apparmor/lsm.c             |  4 +--
 6 files changed, 76 insertions(+), 21 deletions(-)

-- 
1.9.1


             reply	other threads:[~2014-08-11 13:54 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-11 13:52 Jani Nikula [this message]
2014-08-11 13:52 ` [PATCH 1/4] module: rename KERNEL_PARAM_FL_NOARG to avoid confusion Jani Nikula
2014-08-11 13:52 ` [PATCH 2/4] module: make it possible to have unsafe, tainting module params Jani Nikula
2014-08-11 13:52 ` [PATCH 3/4] module: add module_param_unsafe and module_param_named_unsafe Jani Nikula
2014-08-11 13:52 ` [PATCH 4/4] drm/i915: taint the kernel if unsafe module parameters are set Jani Nikula
2014-08-13 20:25 ` [PATCH 0/4] module: add support for unsafe, tainting parameters Rusty Russell
2014-08-14  5:21   ` Daniel Vetter
2014-08-20 16:12     ` Rusty Russell
2014-08-21  7:00       ` Jani Nikula

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1407764272.git.jani.nikula@intel.com \
    --to=jani.nikula@intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=daniel.vetter@ffwll.ch \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jon.mason@intel.com \
    --cc=khali@linux-fr.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rusty@rustcorp.com.au \
    --cc=zhong@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox