From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753068AbbCIMD7 (ORCPT ); Mon, 9 Mar 2015 08:03:59 -0400 Received: from smtp3-g21.free.fr ([212.27.42.3]:44684 "EHLO smtp3-g21.free.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750976AbbCIMDr (ORCPT ); Mon, 9 Mar 2015 08:03:47 -0400 From: Yann Droneaud To: Peter Zijlstra , Paul Mackerras , Ingo Molnar , Arnaldo Carvalho de Melo , Jiri Olsa Cc: Yann Droneaud , Adrian Hunter , David Ahern , David Ahern , Frederic Weisbecker , Jiri Olsa , Namhyung Kim , Peter Zijlstra , Stephane Eranian , William Cohen , linux-kernel@vger.kernel.org Subject: [PATCH v1 0/2] perf tool: improve error handling in perf_flag_probe() Date: Mon, 9 Mar 2015 13:01:14 +0100 Message-Id: X-Mailer: git-send-email 2.1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Following the EBUSY errors reported by Jiri Olsa [1], I've tryed to improve a bit the way perf_flag_probe() handle errors. In case EBUSY is returned by perf_event_open(), testing the function again without PERF_FLAG_FD_CLOEXEC is meaningless: EBUSY is not related to close-on-exec flag, so there's nothing to confirm. For other errors, not yet explicitly handled by perf_flag_probe(), it's pointless to report a second error message for the same error code: the second check should not print an error if the error is the same as the one returned for the first check. Changes from v0 [2]: - rebased on top of commit 48536c9195ae ("perf tools: Fix probing for PERF_FLAG_FD_CLOEXEC flag"); - update a bit commit message; - the previous patchset was acked by Jiri[3], but I haven't reported Acked-by: in this updated patchset. [1] http://lkml.kernel.org/r/1406908014-8312-1-git-send-email-jolsa@kernel.org [2] http://lkml.kernel.org/r/cover.1410595700.git.ydroneaud@opteya.com [3] http://lkml.kernel.org/r/20140920121438.GB15481@krava.brq.redhat.com Yann Droneaud (2): perf tools: shortcut PERF_FLAG_FD_CLOEXEC probing in case of EBUSY error perf tools: report PERF_FLAG_FD_CLOEXEC probing error once tools/perf/util/cloexec.c | 27 ++++++++++++++++----------- 1 file changed, 16 insertions(+), 11 deletions(-) Regards. -- Yann Droneaud OPTEYA