Re: [PATCH v5 4/6] i2c: at91: add support for new alternative command mode

Wolfram Sang
2015-06-09T22:19:55Z

[-- Attachment #1: Type: text/plain, Size: 313 bytes --]

Nicolas,

> > +static struct at91_twi_pdata at91sama5d2_config = {
>
> No, please name it:
>
> "sama5d2_config"

Thanks for your input, but please don't quote the whole mail for those
tiny comments. Only the relevant parts, please. Otherwise it is too easy
to miss things.

Thanks,

Wolfram

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]