From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755761AbbGHWhn (ORCPT ); Wed, 8 Jul 2015 18:37:43 -0400 Received: from mga01.intel.com ([192.55.52.88]:26747 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753206AbbGHWfv (ORCPT ); Wed, 8 Jul 2015 18:35:51 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.15,434,1432623600"; d="scan'208";a="760894288" From: Tom Zanussi To: linux-kernel@vger.kernel.org Cc: rostedt@goodmis.org, pebolle@tiscali.nl, rientjes@google.com, Tom Zanussi Subject: [PATCH v3 0/7] kallsyms header cleanup Date: Wed, 8 Jul 2015 17:35:08 -0500 Message-Id: X-Mailer: git-send-email 1.9.3 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org During review of an unrelated patchset, the question was asked why module.h was included in code that wouldn't be a module and didn't do anything with modules [1]. The reason is that it uses kallsyms defines, but kallsyms.h doesn't include module.h, though it should because it uses MODULE_NAME_LEN. The code in question also didn't include kallsyms.h but relied on ftrace.h to pull it in. But ftrace.h no longer contains anything that needs kallsyms.h, and continues to include it only because other code expects it to. This patchset is the start of cleaning all that up. It also adds explicit kallsyms.h includes and removes module.h includes for obvious cases in kernel/trace and lib/, where I happened to be working. There are a bunch of other files that probably include module.h only for kallsyms, but I haven't gone through them yet. I can submit a follow-on patchset to this one assuming this is best way to do it... [1] https://lkml.org/lkml/2015/4/4/70 Changes from v2: - rebased to linux-next - trace.c now needs module.h so leave it Changes from v1: - added KSYM_SYMBOL_LEN patches for fnic and slub - separated tracing changes into KSYM_SYMBOL_LEN-only module.h changes - fixed up bogus lib change from previous patchset - separate patch to remove unnecessary tracing kallsyms.h and module.h usage The following changes since commit d3e8e8e541efab6d818008e24a71a5a9e99a8df6: Add linux-next specific files for 20150706 (2015-07-06 13:52:06 +1000) are available in the git repository at: git://git.yoctoproject.org/linux-yocto-contrib.git tzanussi/kallsyms-header-cleanup-v3 http://git.yoctoproject.org/cgit/cgit.cgi/linux-yocto-contrib/log/?h=tzanussi/kallsyms-header-cleanup-v3 Tom Zanussi (7): tracing: Remove kallsyms.h include from linux/ftrace.h kallsyms: Add module.h include tracing: Remove redundant module.h includes lib: Remove redundant module.h includes fnic: Remove redundant module.h includes slub: Remove redundant module.h includes tracing: Remove unnecessary kallsyms.h and module.h includes drivers/scsi/fnic/fnic_trace.c | 1 - include/linux/ftrace.h | 1 - include/linux/kallsyms.h | 1 + kernel/trace/trace.c | 1 - kernel/trace/trace_branch.c | 2 -- kernel/trace/trace_export.c | 2 -- kernel/trace/trace_irqsoff.c | 2 -- kernel/trace/trace_kprobe.c | 1 + kernel/trace/trace_output.c | 2 +- kernel/trace/trace_sched_switch.c | 2 -- kernel/trace/trace_sched_wakeup.c | 2 -- kernel/trace/trace_stack.c | 2 -- kernel/trace/trace_syscalls.c | 2 +- lib/vsprintf.c | 1 - mm/slub.c | 1 - 15 files changed, 4 insertions(+), 19 deletions(-) -- 1.9.3