From: Joshua Clayton <stillcompiling@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: [PATCH v4 REPOST 0/8] clean up wlan_bssdef.h
Date: Wed, 5 Aug 2015 17:17:13 -0700 [thread overview]
Message-ID: <cover.1438778593.git.stillcompiling@gmail.com> (raw)
I posted v4 of this patch set a week ago and there have been no
comments. I hope this is a good sign that the patches are good.
However, I have noticed that I managed to use the same message id
for the coverletter of v4 as for v3, which might have caused people
to hold off reviewing, perhaps thinking that earlier comments
had not been addressed.
Better safe than sorry, so I am reposting v4
My apologies for the noise on the mailing list.
The main goal of this series is to get rid of a needless typedef
in the rtl8712 wlan driver.
In the course of fixing that, I found a bug that can (at least in theory)
lead to a overrun during a memcpy, as well as an identical struct with
a different name, which use the typedef.
Finally after cleaning up the typedef, change the name of the primary
variable that used the typedef from "SupportedRates" to "rates", to
conform to kernel coding style.
Changes since V1:
Do not make other logic changes while Changing the name of SupportedRates
New patch 3/6 fixes a buggy comment that referred to the typedef
Changes since V2:
broke former patch 4 into 3 parts, as it was too big for git-send-email
Changes since V3:
In patch 8/8 Change the line wrapping of lines that fit within 80
characters, removing superfluous "== true" expressions that would
otherwise keep the lines overlong.
Joshua Clayton (8):
staging: rtl8712: fix buggy size calculation
staging: rtl8712: simplify size calculation
staging: rtl8712: fix comment
staging: rtl8712: removed unused wrapper structs
staging: rtl8712: remove duplicate struct
staging: rtl8712: rename function
staging: rtl8712: remove typedefs
staging: rtl8712: change SupportedRates to rates
drivers/staging/rtl8712/ieee80211.c | 25 +++++++-------
drivers/staging/rtl8712/rtl871x_cmd.c | 28 +++++-----------
drivers/staging/rtl8712/rtl871x_cmd.h | 18 ----------
drivers/staging/rtl8712/rtl871x_event.h | 2 +-
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 34 +++++++++----------
drivers/staging/rtl8712/rtl871x_mlme.c | 47 ++++++++++-----------------
drivers/staging/rtl8712/rtl871x_mlme.h | 2 +-
drivers/staging/rtl8712/rtl871x_mp_ioctl.c | 6 ++--
drivers/staging/rtl8712/wlan_bssdef.h | 42 +++---------------------
9 files changed, 62 insertions(+), 142 deletions(-)
--
2.5.0
next reply other threads:[~2015-08-06 0:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-06 0:17 Joshua Clayton [this message]
2015-08-06 0:17 ` [PATCH v4 REPOST 1/8] staging: rtl8712: fix buggy size calculation Joshua Clayton
2015-08-06 0:17 ` [PATCH v4 REPOST 2/8] staging: rtl8712: simplify " Joshua Clayton
2015-08-06 0:17 ` [PATCH v4 REPOST 3/8] staging: rtl8712: fix comment Joshua Clayton
2015-08-06 0:17 ` [PATCH v4 REPOST 4/8] staging: rtl8712: removed unused wrapper structs Joshua Clayton
2015-08-06 0:17 ` [PATCH v4 REPOST 5/8] staging: rtl8712: remove duplicate struct Joshua Clayton
2015-08-06 0:17 ` [PATCH v4 REPOST 6/8] staging: rtl8712: rename function Joshua Clayton
2015-08-06 0:17 ` [PATCH v4 REPOST 7/8] staging: rtl8712: remove typedefs Joshua Clayton
2015-08-06 0:17 ` [PATCH v4 REPOST 8/8] staging: rtl8712: change SupportedRates to rates Joshua Clayton
2015-08-06 8:06 ` [PATCH v4 REPOST 0/8] clean up wlan_bssdef.h Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1438778593.git.stillcompiling@gmail.com \
--to=stillcompiling@gmail.com \
--cc=Julia.Lawall@lip6.fr \
--cc=Larry.Finger@lwfinger.net \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=florian.c.schilhabel@googlemail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nitinkuppelur@gmail.com \
--cc=sudipm.mukherjee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox