[PATCH V1 1/2] mfd: da9053: Addition of extra registers for GPIOs 8-13

[PATCH V1 1/2] mfd: da9053: Addition of extra registers for GPIOs 8-13

[Steve Twiss]

From: Steve Twiss <stwiss.opensource@diasemi.com>

Definitions for GPIO registers 8, 9, 10, 11, 12 and 13 are added into
the register header file.

- DA9052_GPIO_8_9_REG    25
- DA9052_GPIO_10_11_REG  26
- DA9052_GPIO_12_13_REG  27

A modification is also made to the MFD core code to define these registers
as readable and writable. The functions for da9052_reg_readable() and
da9052_reg_writeable() have had their case statements altered to include
these new registers.

Signed-off-by: Steve Twiss <stwiss.opensource@diasemi.com>

---
This patch applies against linux-next and v4.3-rc4 


 drivers/mfd/da9052-core.c      | 6 ++++++
 include/linux/mfd/da9052/reg.h | 3 +++
 2 files changed, 9 insertions(+)

diff --git a/drivers/mfd/da9052-core.c b/drivers/mfd/da9052-core.c
index 46e3840..c0bf68a 100644
--- a/drivers/mfd/da9052-core.c
+++ b/drivers/mfd/da9052-core.c
@@ -51,6 +51,9 @@ static bool da9052_reg_readable(struct device *dev, unsigned int reg)
 	case DA9052_GPIO_2_3_REG:
 	case DA9052_GPIO_4_5_REG:
 	case DA9052_GPIO_6_7_REG:
+	case DA9052_GPIO_8_9_REG:
+	case DA9052_GPIO_10_11_REG:
+	case DA9052_GPIO_12_13_REG:
 	case DA9052_GPIO_14_15_REG:
 	case DA9052_ID_0_1_REG:
 	case DA9052_ID_2_3_REG:
@@ -178,6 +181,9 @@ static bool da9052_reg_writeable(struct device *dev, unsigned int reg)
 	case DA9052_GPIO_2_3_REG:
 	case DA9052_GPIO_4_5_REG:
 	case DA9052_GPIO_6_7_REG:
+	case DA9052_GPIO_8_9_REG:
+	case DA9052_GPIO_10_11_REG:
+	case DA9052_GPIO_12_13_REG:
 	case DA9052_GPIO_14_15_REG:
 	case DA9052_ID_0_1_REG:
 	case DA9052_ID_2_3_REG:
diff --git a/include/linux/mfd/da9052/reg.h b/include/linux/mfd/da9052/reg.h
index c4dd3a8..5010f97 100644
--- a/include/linux/mfd/da9052/reg.h
+++ b/include/linux/mfd/da9052/reg.h
@@ -65,6 +65,9 @@
 #define DA9052_GPIO_2_3_REG		22
 #define DA9052_GPIO_4_5_REG		23
 #define DA9052_GPIO_6_7_REG		24
+#define DA9052_GPIO_8_9_REG		25
+#define DA9052_GPIO_10_11_REG		26
+#define DA9052_GPIO_12_13_REG		27
 #define DA9052_GPIO_14_15_REG		28
 
 /* POWER SEQUENCER CONTROL REGISTERS */
-- 
end-of-patch for PATCH V1

[PATCH V1 2/2] regulator: da9053: Add regulator support for DA9053 BB silicon

[Steve Twiss]

From: Steve Twiss <stwiss.opensource@diasemi.com>

Provide an additional case entry for DA9053_BC in the find_regulator_info()
function in order to support BB type silicon for the DA9053 device.

Signed-off-by: Steve Twiss <stwiss.opensource@diasemi.com>

---
This patch applies against linux-next and v4.3-rc4 


 drivers/regulator/da9052-regulator.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/regulator/da9052-regulator.c b/drivers/regulator/da9052-regulator.c
index e628d4c..12a25b4 100644
--- a/drivers/regulator/da9052-regulator.c
+++ b/drivers/regulator/da9052-regulator.c
@@ -381,6 +381,7 @@ static inline struct da9052_regulator_info *find_regulator_info(u8 chip_id,
 	case DA9053_AA:
 	case DA9053_BA:
 	case DA9053_BB:
+	case DA9053_BC:
 		for (i = 0; i < ARRAY_SIZE(da9053_regulator_info); i++) {
 			info = &da9053_regulator_info[i];
 			if (info->reg_desc.id == id)
-- 
end-of-patch for PATCH V1

[PATCH V1 0/2] Add DA9021 support to the existing DA9052/53 driver

[Steve Twiss]

From: Steve Twiss <stwiss.opensource@diasemi.com>

Two patches to add missing registers and add support for DA9053-BB
silicon in the regulators component. These patches modify existing
files for the Dialog Power Management IC driver for the DA9052/53
devices.

In this patch set the following is provided:
 - [PATCH V1 1/3]: Addition of extra registers for GPIOs 8-13
 - [PATCH V1 2/3]: Add regulator support for DA9053 BB silicon

This patch applies against linux-next and v4.3-rc4 

Thank you,
Steve Twiss, Dialog Semiconductor Ltd.

Steve Twiss (2):
  mfd: da9053: Addition of extra registers for GPIOs 8-13
  regulator: da9053: Add regulator support for DA9053 BB silicon

 drivers/mfd/da9052-core.c            | 6 ++++++
 drivers/regulator/da9052-regulator.c | 1 +
 include/linux/mfd/da9052/reg.h       | 3 +++
 3 files changed, 10 insertions(+)

-- 
end-of-patch for PATCH V1

Re: [PATCH V1 0/2] Add DA9021 support to the existing DA9052/53 driver

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 637 bytes --]

On Thu, Oct 08, 2015 at 04:17:52PM +0100, Steve Twiss wrote:
> From: Steve Twiss <stwiss.opensource@diasemi.com>
> 
> Two patches to add missing registers and add support for DA9053-BB
> silicon in the regulators component. These patches modify existing
> files for the Dialog Power Management IC driver for the DA9052/53
> devices.
> 
> In this patch set the following is provided:
>  - [PATCH V1 1/3]: Addition of extra registers for GPIOs 8-13
>  - [PATCH V1 2/3]: Add regulator support for DA9053 BB silicon
> 
> This patch applies against linux-next and v4.3-rc4 

Are there any dependencies between the two patches?

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

RE: [PATCH V1 0/2] Add DA9021 support to the existing DA9052/53 driver

[Opensource [Steve Twiss]]

On 09 October 2015 12:36 Mark Brown wrote:

> To: Opensource [Steve Twiss]
> Cc: LINUXKERNEL; Lee Jones; Liam Girdwood; Samuel Ortiz; David Dajun
> Chen; Support Opensource
> Subject: Re: [PATCH V1 0/2] Add DA9021 support to the existing DA9052/53 driver
> 
> On Thu, Oct 08, 2015 at 04:17:52PM +0100, Steve Twiss wrote:
> > From: Steve Twiss <stwiss.opensource@diasemi.com>
> >
> > Two patches to add missing registers and add support for DA9053-BB
> > silicon in the regulators component. These patches modify existing
> > files for the Dialog Power Management IC driver for the DA9052/53
> > devices.
> >
> > In this patch set the following is provided:
> >  - [PATCH V1 1/3]: Addition of extra registers for GPIOs 8-13
> >  - [PATCH V1 2/3]: Add regulator support for DA9053 BB silicon
> >
> > This patch applies against linux-next and v4.3-rc4
> 
> Are there any dependencies between the two patches?

Nope. 
I just thought because they were for MFD and regulators I would separate them.
Do you want me to merge them into a single patch and re-send?

Regards,
Steve

RE: [PATCH V1 0/2] Add DA9021 support to the existing DA9052/53 driver

[Opensource [Steve Twiss]]

On 09 October 2015 13:52 Steve Twiss wrote:

> To: Mark Brown; Lee Jones
> Cc: LINUXKERNEL; Liam Girdwood; Samuel Ortiz; David Dajun Chen; Support Opensource
> Subject: RE: [PATCH V1 0/2] Add DA9021 support to the existing DA9052/53 driver
> 
> On 09 October 2015 12:36 Mark Brown wrote:
> 
> > To: Opensource [Steve Twiss]
> > Cc: LINUXKERNEL; Lee Jones; Liam Girdwood; Samuel Ortiz; David Dajun
> > Chen; Support Opensource
> > Subject: Re: [PATCH V1 0/2] Add DA9021 support to the existing DA9052/53 driver
> >

The title of my previous cover note is just wrong and just doesn't make sense!
They were supposed to be fixes for the DA9053 driver.

> > On Thu, Oct 08, 2015 at 04:17:52PM +0100, Steve Twiss wrote:
> > > From: Steve Twiss <stwiss.opensource@diasemi.com>
> > >
> > > Two patches to add missing registers and add support for DA9053-BB
> > > silicon in the regulators component. These patches modify existing
> > > files for the Dialog Power Management IC driver for the DA9052/53
> > > devices.
> > >
> > > In this patch set the following is provided:
> > >  - [PATCH V1 1/3]: Addition of extra registers for GPIOs 8-13
> > >  - [PATCH V1 2/3]: Add regulator support for DA9053 BB silicon
> > >
> > > This patch applies against linux-next and v4.3-rc4

Mark & Lee, these two patches for DA9052/3 are correct, but at your discretion,
you are welcome to ignore them and I will resend with a cover note that makes
sense later.

I shouldn't submit when I have the flu.

Steve

Re: [PATCH V1 0/2] Add DA9021 support to the existing DA9052/53 driver

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 654 bytes --]

On Fri, Oct 09, 2015 at 12:52:00PM +0000, Opensource [Steve Twiss] wrote:
> On 09 October 2015 12:36 Mark Brown wrote:

> > Are there any dependencies between the two patches?

> Nope. 
> I just thought because they were for MFD and regulators I would separate them.
> Do you want me to merge them into a single patch and re-send?

No, the point is that if you send a series the assumption will normally
be that later patches depend on earlier patches so a cross tree merge or
carrying things in a non-default tree is required to get everything
integrated.

If there are no dependencies it's clearer to just send each patch
individually.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

Re: [PATCH V1 1/2] mfd: da9053: Addition of extra registers for GPIOs 8-13

[Lee Jones]

On Thu, 08 Oct 2015, Steve Twiss wrote:

> From: Steve Twiss <stwiss.opensource@diasemi.com>
> 
> Definitions for GPIO registers 8, 9, 10, 11, 12 and 13 are added into
> the register header file.
> 
> - DA9052_GPIO_8_9_REG    25
> - DA9052_GPIO_10_11_REG  26
> - DA9052_GPIO_12_13_REG  27
> 
> A modification is also made to the MFD core code to define these registers
> as readable and writable. The functions for da9052_reg_readable() and
> da9052_reg_writeable() have had their case statements altered to include
> these new registers.
> 
> Signed-off-by: Steve Twiss <stwiss.opensource@diasemi.com>
> 
> ---
> This patch applies against linux-next and v4.3-rc4 
> 
> 
>  drivers/mfd/da9052-core.c      | 6 ++++++
>  include/linux/mfd/da9052/reg.h | 3 +++
>  2 files changed, 9 insertions(+)

Applied, thanks.

> diff --git a/drivers/mfd/da9052-core.c b/drivers/mfd/da9052-core.c
> index 46e3840..c0bf68a 100644
> --- a/drivers/mfd/da9052-core.c
> +++ b/drivers/mfd/da9052-core.c
> @@ -51,6 +51,9 @@ static bool da9052_reg_readable(struct device *dev, unsigned int reg)
>  	case DA9052_GPIO_2_3_REG:
>  	case DA9052_GPIO_4_5_REG:
>  	case DA9052_GPIO_6_7_REG:
> +	case DA9052_GPIO_8_9_REG:
> +	case DA9052_GPIO_10_11_REG:
> +	case DA9052_GPIO_12_13_REG:
>  	case DA9052_GPIO_14_15_REG:
>  	case DA9052_ID_0_1_REG:
>  	case DA9052_ID_2_3_REG:
> @@ -178,6 +181,9 @@ static bool da9052_reg_writeable(struct device *dev, unsigned int reg)
>  	case DA9052_GPIO_2_3_REG:
>  	case DA9052_GPIO_4_5_REG:
>  	case DA9052_GPIO_6_7_REG:
> +	case DA9052_GPIO_8_9_REG:
> +	case DA9052_GPIO_10_11_REG:
> +	case DA9052_GPIO_12_13_REG:
>  	case DA9052_GPIO_14_15_REG:
>  	case DA9052_ID_0_1_REG:
>  	case DA9052_ID_2_3_REG:
> diff --git a/include/linux/mfd/da9052/reg.h b/include/linux/mfd/da9052/reg.h
> index c4dd3a8..5010f97 100644
> --- a/include/linux/mfd/da9052/reg.h
> +++ b/include/linux/mfd/da9052/reg.h
> @@ -65,6 +65,9 @@
>  #define DA9052_GPIO_2_3_REG		22
>  #define DA9052_GPIO_4_5_REG		23
>  #define DA9052_GPIO_6_7_REG		24
> +#define DA9052_GPIO_8_9_REG		25
> +#define DA9052_GPIO_10_11_REG		26
> +#define DA9052_GPIO_12_13_REG		27
>  #define DA9052_GPIO_14_15_REG		28
>  
>  /* POWER SEQUENCER CONTROL REGISTERS */

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

RE: [PATCH V1 1/2] mfd: da9053: Addition of extra registers for GPIOs 8-13

[Opensource [Steve Twiss]]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 1282 bytes --]

On 13 October 2015 08:32 Lee Jones wrote:

> To: Opensource [Steve Twiss]
> Cc: LINUXKERNEL; Samuel Ortiz; David Dajun Chen; Support Opensource
> Subject: Re: [PATCH V1 1/2] mfd: da9053: Addition of extra registers for
> GPIOs 8-13
> 
> On Thu, 08 Oct 2015, Steve Twiss wrote:
> 
> > From: Steve Twiss <stwiss.opensource@diasemi.com>
> >
> > Definitions for GPIO registers 8, 9, 10, 11, 12 and 13 are added into
> > the register header file.
> >
> > - DA9052_GPIO_8_9_REG    25
> > - DA9052_GPIO_10_11_REG  26
> > - DA9052_GPIO_12_13_REG  27
> >
> > A modification is also made to the MFD core code to define these registers
> > as readable and writable. The functions for da9052_reg_readable() and
> > da9052_reg_writeable() have had their case statements altered to include
> > these new registers.
> >
> > Signed-off-by: Steve Twiss <stwiss.opensource@diasemi.com>
> >
> > ---
> > This patch applies against linux-next and v4.3-rc4
> >
> >
> >  drivers/mfd/da9052-core.c      | 6 ++++++
> >  include/linux/mfd/da9052/reg.h | 3 +++
> >  2 files changed, 9 insertions(+)
> 
> Applied, thanks.

Thanks Lee.
Regards,
Steve
ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a­¢f£¢·hšïêÿ‘êçz_è®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨è­Ú&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥