From: Joshua Clayton <stillcompiling@gmail.com>
To: Mark Brown <broonie@kernel.org>, linux-spi@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
Anton Bondarenko <anton.bondarenko.sama@gmail.com>,
Joshua Clayton <stillcompiling@gmail.com>
Subject: [PATCH v2 0/6] spi: Add file i/o to spidev_test
Date: Wed, 18 Nov 2015 14:30:36 -0800 [thread overview]
Message-ID: <cover.1447880230.git.stillcompiling@gmail.com> (raw)
In-Reply-To: <2760715.DGIOLUoqL9@jclayton-pc>
Add to spidev_test, the ability to read from and write to a file.
Clean up code along the way.
As I finished, I found that a request has been made to move
spidev_test from Documentation to tools, so I did that as well.
Thanks to Mark Brown and Anton Bodarenko for feedback on v1
v2 Changes:
- Move spidev_test to tools in the first commit instead of the last.
- Drop the patch that formats tools/Makefile
- Drop the patch that changes rx to a local variable in transfer()
- Check the result of malloc everywhere it is called.
- Change all the patch subjects to spi: spidev_test
- Removed a check of the spi transfer buffer size, in favor of
letting the kernel give an error in the ioctl if too big.
Joshua Clayton (6):
spi: Move spi code from Documentation to tools
spi: spidev_test: transfer_escaped_string function
spi: spidev_test: accept input from a file
spi: spidev_test: output to a file
spi: spidev_test: check error
spi: spidev_test: fix whitespace
Documentation/Makefile | 2 +-
Documentation/spi/Makefile | 8 -
Documentation/spi/spidev_fdx.c | 158 ----------------
Documentation/spi/spidev_test.c | 318 --------------------------------
tools/Makefile | 7 +-
tools/spi/Makefile | 4 +
tools/spi/spidev_fdx.c | 158 ++++++++++++++++
tools/spi/spidev_test.c | 399 ++++++++++++++++++++++++++++++++++++++++
8 files changed, 566 insertions(+), 488 deletions(-)
delete mode 100644 Documentation/spi/Makefile
delete mode 100644 Documentation/spi/spidev_fdx.c
delete mode 100644 Documentation/spi/spidev_test.c
create mode 100644 tools/spi/Makefile
create mode 100644 tools/spi/spidev_fdx.c
create mode 100644 tools/spi/spidev_test.c
--
2.5.0
next prev parent reply other threads:[~2015-11-18 22:31 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-17 15:24 [PATCH 0/8] spi: Add file i/o to spidev_test Joshua Clayton
2015-11-17 15:24 ` [PATCH 1/8] Documentation/spi/spidev_test.c: use one rx buffer Joshua Clayton
2015-11-17 17:41 ` Mark Brown
2015-11-17 18:58 ` Joshua Clayton
2015-11-17 15:24 ` [PATCH 2/8] Documentation/spi/spidev_test.c: clean up input_tx Joshua Clayton
2015-11-17 17:43 ` Mark Brown
2015-11-17 19:21 ` Joshua Clayton
2015-11-17 22:52 ` Mark Brown
2015-11-17 15:24 ` [PATCH 3/8] Documentation/spi/spidev_test.c: accept input from a file Joshua Clayton
2015-11-17 18:26 ` Anton Bondarenko
2015-11-17 18:46 ` Mark Brown
2015-11-17 19:28 ` Joshua Clayton
2015-11-17 15:24 ` [PATCH 4/8] Documentation/spi/spidev_test.c: output to " Joshua Clayton
2015-11-17 15:24 ` [PATCH 5/8] Documentation/spi/spidev_test.c: check error Joshua Clayton
2015-11-17 15:24 ` [PATCH 6/8] Documentation/spi/spidev_test.c: fix whitespace Joshua Clayton
2015-11-17 15:24 ` [PATCH 7/8] tools/Makefile: minor whitespace cleanup Joshua Clayton
2015-11-17 18:09 ` Mark Brown
2015-11-17 19:41 ` Joshua Clayton
2015-11-17 15:24 ` [PATCH 8/8] spi: Move spi code from Documentation to tools Joshua Clayton
2015-11-17 18:11 ` Mark Brown
2015-11-17 15:37 ` [PATCH 0/8] spi: Add file i/o to spidev_test Mark Brown
2015-11-17 16:15 ` Joshua Clayton
2015-11-17 16:53 ` Mark Brown
2015-11-18 22:30 ` Joshua Clayton [this message]
2015-11-18 22:30 ` [PATCH v2 1/6] spi: Move spi code from Documentation to tools Joshua Clayton
2015-11-18 22:30 ` [PATCH v2 2/6] spi: spidev_test: transfer_escaped_string function Joshua Clayton
2015-11-18 22:30 ` [PATCH v2 3/6] spi: spidev_test: accept input from a file Joshua Clayton
2015-11-18 22:30 ` [PATCH v2 4/6] spi: spidev_test: output to " Joshua Clayton
2015-11-18 22:30 ` [PATCH v2 5/6] spi: spidev_test: check error Joshua Clayton
2015-11-18 22:30 ` [PATCH v2 6/6] spi: spidev_test: fix whitespace Joshua Clayton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1447880230.git.stillcompiling@gmail.com \
--to=stillcompiling@gmail.com \
--cc=anton.bondarenko.sama@gmail.com \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox