linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: John Youn <johnyoun@synopsys.com>
To: linux-usb@vger.kernel.org
To: Doug Anderson <dianders@chromium.org>
Cc: johnyoun@synopsys.com
Cc: Felipe Balbi <balbi@ti.com>
Cc: Stefan Wahren <stefan.wahren@i2se.com>
Cc: Michael Niewoehner <linux@mniewoehner.de>
Cc: Tao Huang <huangtao@rock-chips.com>
Cc: Julius Werner <jwerner@chromium.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org
Cc: linux-usb@vger.kernel.org
Cc: Caesar Wang <caesar.upstream@gmail.com>
Cc: Heiko Stuebner <heiko@sntech.de>
Cc: Felipe Balbi <balbi@kernel.org>
Cc: Remi Pommarel <repk@triplefau.lt>
Cc: Kever Yang <kever.yang@rock-chips.com>
Cc: Przemek Rudy <prudy1@o2.pl>
Subject: [RFT PATCH 0/4] usb: dwc2: Fix core reset and force mode delay problems
Date: Mon, 28 Mar 2016 19:36:25 -0700	[thread overview]
Message-ID: <cover.1459211397.git.johnyoun@synopsys.com> (raw)

Hi,

The following patch series addresses the core reset and force mode
delay problems we have been seeing on dwc2 for some platforms.

I think I have identified the source of the inconsistencies between
platforms and this series attempts to address them.

Basically everything stems from the IDDIG debounce filter delay, which
is a function of the PHY clock speed and can range from 5-50 ms if
enabled. This delay must be taken into account on core reset and force
modes. A full explanation is provided in the patch commit log and code
comments.

The first two patches are prerequisites to the force mode fixes,
including one patch that was sent separately by Przemek Rudy. I have
resubmitted it with this series for convenience.

Please help by reviewing and testing on your platforms.

Patches were tested on:
* Synopsys HAPS platform IP 3.20a OTG, dr_mode=OTG,HOST,PERIPHERAL

Regards,
John

John Youn (3):
  usb: dwc2: gadget: Only initialize device if in device mode
  usb: dwc2: Add delay to core soft reset
  usb: dwc2: Properly account for the force mode delays

Przemek Rudy (1):
  usb: dwc2: do not override forced dr_mode in gadget setup

 drivers/usb/dwc2/core.c     | 195 ++++++++++++++++++++++++++++----------------
 drivers/usb/dwc2/core.h     |   2 +-
 drivers/usb/dwc2/gadget.c   |  30 +++++--
 drivers/usb/dwc2/hcd.c      |   6 +-
 drivers/usb/dwc2/hw.h       |   1 +
 drivers/usb/dwc2/platform.c |   9 +-
 6 files changed, 161 insertions(+), 82 deletions(-)

-- 
2.7.4

             reply	other threads:[~2016-03-29  2:36 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-29  2:36 John Youn [this message]
2016-03-29  2:36 ` [RFT PATCH 1/4] usb: dwc2: do not override forced dr_mode in gadget setup John Youn
2016-03-29  2:36 ` [RFT PATCH 2/4] usb: dwc2: gadget: Only initialize device if in device mode John Youn
2016-03-29  2:36 ` [RFT PATCH 3/4] usb: dwc2: Add delay to core soft reset John Youn
2016-03-29  2:36 ` [RFT PATCH 4/4] usb: dwc2: Properly account for the force mode delays John Youn
2016-03-31  8:52 ` [RFT PATCH 0/4] usb: dwc2: Fix core reset and force mode delay problems Stefan Wahren
2016-03-31 20:45 ` Michael Niewoehner
2016-03-31 21:43 ` Michael Niewoehner
2016-04-07 18:41   ` John Youn
2016-04-07 20:36     ` Michael Niewoehner
2016-04-07 22:12       ` John Youn
2016-04-08 10:25         ` Michael Niewoehner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1459211397.git.johnyoun@synopsys.com \
    --to=johnyoun@synopsys.com \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).