Re: [PATCH v2 2/2] ti-adc081c: Initial triggered buffer support

kbuild test robot
2016-04-04T18:41:08Z

[-- Attachment #1: Type: text/plain, Size: 2026 bytes --]

Hi Crestez,

[auto build test WARNING on iio/togreg]
[also build test WARNING on v4.6-rc2 next-20160404]
[if your patch is applied to the wrong git tree, please drop us a note to help improving the system]

url: https://github.com/0day-ci/linux/commits/Crestez-Dan-Leonard/Add-support-for-adc101c-and-adc121c/20160405-022459
base: https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git togreg
config: s390-allmodconfig (attached as .config)
reproduce:
wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=s390

All warnings (new ones prefixed by >>):

drivers/iio/adc/ti-adc081c.c: In function 'adc081c_trigger_handler':
>> drivers/iio/adc/ti-adc081c.c:130:1: warning: 'adc081c_trigger_handler' uses dynamic stack allocation
}
^

vim +/adc081c_trigger_handler +130 drivers/iio/adc/ti-adc081c.c

114 static irqreturn_t adc081c_trigger_handler(int irq, void *p)
115 {
116 struct iio_poll_func *pf = p;
117 struct iio_dev *indio_dev = pf->indio_dev;
118 struct adc081c *data = iio_priv(indio_dev);
119 u16 buf[indio_dev->scan_bytes / 2];
120 int ret;
121
122 ret = i2c_smbus_read_word_swapped(data->i2c, REG_CONV_RES);
123 if (ret < 0)
124 goto out;
125 buf[0] = ret;
126 iio_push_to_buffers_with_timestamp(indio_dev, buf, iio_get_time_ns());
127 out:
128 iio_trigger_notify_done(indio_dev->trig);
129 return IRQ_HANDLED;
> 130 }
131
132 static int adc081c_probe(struct i2c_client *client,
133 const struct i2c_device_id *id)
134 {
135 struct iio_dev *iio;
136 struct adc081c *adc;
137 struct adcxx1c_model *model = (struct adcxx1c_model*)id->driver_data;
138 int err;

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/octet-stream, Size: 40033 bytes --]