From: Pratyush Anand <panand@redhat.com>
To: mingo@kernel.org, alexandre.belloni@free-electrons.com,
tglx@linutronix.de, hpa@zytor.com, x86@kernel.org
Cc: rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org,
prarit@redhat.com, dyoung@redhat.com, a.zummo@towertech.it,
Pratyush Anand <panand@redhat.com>
Subject: [PATCH V2 0/2] rtc-cmos: Workaround unwanted interrupt generation
Date: Tue, 2 Aug 2016 12:56:58 +0530 [thread overview]
Message-ID: <cover.1470122380.git.panand@redhat.com> (raw)
We have observed on few machines with rtc-cmos device that
hpet_rtc_interrupt() is called before cmos_do_probe() could call
hpet_rtc_timer_init(). It has not been observed during normal boot/reboot
of machines. It *sometime* happens when system is booted with kdump
secondary kernel. So, neither hpet_default_delta nor hpet_t1_cmp is
initialized by the time interrupt is raised in the given situation.
Therefore while loop of hpet_cnt_ahead() in hpet_rtc_timer_reinit() never
completes. This leads to "NMI watchdog: Watchdog detected hard LOCKUP on
cpu 0".
These patch set initializes hpet_default_delta and hpet_t1_cmp before
interrupt can be raised.
Changes since RFC:
- Commit log of patches has been improved.
- RFCs were here: https://lkml.org/lkml/2016/6/21/35
Pratyush Anand (2):
rtc/hpet: Factorize hpet_rtc_timer_init()
rtc/rtc-cmos: Initialize software counters before irq is registered
arch/x86/include/asm/hpet.h | 2 ++
arch/x86/kernel/hpet.c | 41 +++++++++++++++++++++++++++++++++++------
drivers/rtc/rtc-cmos.c | 13 ++++++++++++-
3 files changed, 49 insertions(+), 7 deletions(-)
--
2.5.5
next reply other threads:[~2016-08-02 7:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-02 7:26 Pratyush Anand [this message]
2016-08-02 7:26 ` [PATCH V2 1/2] rtc/hpet: Factorize hpet_rtc_timer_init() Pratyush Anand
2016-08-02 7:27 ` [PATCH V2 2/2] rtc/rtc-cmos: Initialize software counters before irq is registered Pratyush Anand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1470122380.git.panand@redhat.com \
--to=panand@redhat.com \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@free-electrons.com \
--cc=dyoung@redhat.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=prarit@redhat.com \
--cc=rtc-linux@googlegroups.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox