Re: [PATCH v4 2/3] ses: use scsi_is_sas_rphy instead of is_sas_attached

James Bottomley
2016-08-19T01:09:27Z

On Wed, 2016-08-17 at 11:46 +0200, Johannes Thumshirn wrote:
> Use scsi_is_sas_rphy() instead of is_sas_attached() to decide whether
> we should obtain the SAS address from a scsi device or not. This will
> prevent us from tripping on the BUG_ON() in sas_sdev_to_rdev() if the
> rphy isn't attached to the SAS transport class, like it is with
> hpsa's logical devices.

For the entire series:

Reviewed-by: James E.J. Bottomley <jejb@linux.vnet.ibm.com>

> Fixes: 3f8d6f2a0 ('ses: fix discovery of SATA devices in SAS
> enclosures')
> Cc: stable@vger.kernel.org # v4.5+

Except that we can't tag this for stable because without 1/3 it will
induce a compile failure within stable. This means you're going to
have to do the stable process manually and submit both patches to
stable and explain the dependency, once they're upstream.

James