* [PATCH v2 0/2] Staging: unisys: visorbus: style fix
@ 2017-01-07 22:07 Derek Robson
2017-01-07 22:08 ` [PATCH v2 1/2] Staging: unisys: visorbus: visorbus_main.c: fixed style Derek Robson
2017-01-07 22:08 ` [PATCH v2 2/2] Staging: unisys: visorbus: visorchipset.c: style fix Derek Robson
0 siblings, 2 replies; 3+ messages in thread
From: Derek Robson @ 2017-01-07 22:07 UTC (permalink / raw)
To: david.kershner, gregkh, Timothy.Sell
Cc: sparmaintainer, devel, linux-kernel, Derek Robson
Two files change in style fix, changes are octal file permiss
ions.
version 2: first verion has duplicated subject/commit messages
Derek Robson (2):
Staging: unisys: visorbus: visorbus_main.c: fixed style
Staging: unisys: visorbus: visorchipset.c: style fix
drivers/staging/unisys/visorbus/visorbus_main.c | 6 +++---
drivers/staging/unisys/visorbus/visorchipset.c | 2 +-
2 files changed, 4 insertions(+), 4 deletions(-)
--
2.11.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH v2 1/2] Staging: unisys: visorbus: visorbus_main.c: fixed style
2017-01-07 22:07 [PATCH v2 0/2] Staging: unisys: visorbus: style fix Derek Robson
@ 2017-01-07 22:08 ` Derek Robson
2017-01-07 22:08 ` [PATCH v2 2/2] Staging: unisys: visorbus: visorchipset.c: style fix Derek Robson
1 sibling, 0 replies; 3+ messages in thread
From: Derek Robson @ 2017-01-07 22:08 UTC (permalink / raw)
To: david.kershner, gregkh, Timothy.Sell
Cc: sparmaintainer, devel, linux-kernel, Derek Robson
Changed file permissions to octal sytle.
Found using checkpatch.
Acked-by: David Kershner <david.kershner@unisys.com>
Signed-off-by: Derek Robson <robsonde@gmail.com>
---
Version 1 had duplicated subject/commit message, fixed in v2
drivers/staging/unisys/visorbus/visorbus_main.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/unisys/visorbus/visorbus_main.c b/drivers/staging/unisys/visorbus/visorbus_main.c
index 3457ef338e1e..28ca291a4053 100644
--- a/drivers/staging/unisys/visorbus/visorbus_main.c
+++ b/drivers/staging/unisys/visorbus/visorbus_main.c
@@ -984,7 +984,7 @@ create_bus_instance(struct visor_device *dev)
goto err_hdr_info;
}
dev->debugfs_client_bus_info =
- debugfs_create_file("client_bus_info", S_IRUSR | S_IRGRP,
+ debugfs_create_file("client_bus_info", 0440,
dev->debugfs_dir, dev,
&client_bus_info_debugfs_fops);
if (!dev->debugfs_client_bus_info) {
@@ -1337,10 +1337,10 @@ visorbus_exit(void)
debugfs_remove_recursive(visorbus_debugfs_dir);
}
-module_param_named(forcematch, visorbus_forcematch, int, S_IRUGO);
+module_param_named(forcematch, visorbus_forcematch, int, 0444);
MODULE_PARM_DESC(visorbus_forcematch,
"1 to force a successful dev <--> drv match");
-module_param_named(forcenomatch, visorbus_forcenomatch, int, S_IRUGO);
+module_param_named(forcenomatch, visorbus_forcenomatch, int, 0444);
MODULE_PARM_DESC(visorbus_forcenomatch,
"1 to force an UNsuccessful dev <--> drv match");
--
2.11.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH v2 2/2] Staging: unisys: visorbus: visorchipset.c: style fix
2017-01-07 22:07 [PATCH v2 0/2] Staging: unisys: visorbus: style fix Derek Robson
2017-01-07 22:08 ` [PATCH v2 1/2] Staging: unisys: visorbus: visorbus_main.c: fixed style Derek Robson
@ 2017-01-07 22:08 ` Derek Robson
1 sibling, 0 replies; 3+ messages in thread
From: Derek Robson @ 2017-01-07 22:08 UTC (permalink / raw)
To: david.kershner, gregkh, Timothy.Sell
Cc: sparmaintainer, devel, linux-kernel, Derek Robson
Changed file permissions to octal sytle.
Found using checkpatch.
Acked-by: David Kershner <david.kershner@unisys.com>
Signed-off-by: Derek Robson <robsonde@gmail.com>
---
Version 1 had duplicated subject/commit message, fixed in v2
drivers/staging/unisys/visorbus/visorchipset.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/unisys/visorbus/visorchipset.c b/drivers/staging/unisys/visorbus/visorchipset.c
index d7148c351d3f..66944e7534e9 100644
--- a/drivers/staging/unisys/visorbus/visorchipset.c
+++ b/drivers/staging/unisys/visorbus/visorchipset.c
@@ -2277,7 +2277,7 @@ static void exit_unisys(void)
acpi_bus_unregister_driver(&unisys_acpi_driver);
}
-module_param_named(major, visorchipset_major, int, S_IRUGO);
+module_param_named(major, visorchipset_major, int, 0444);
MODULE_PARM_DESC(visorchipset_major,
"major device number to use for the device node");
--
2.11.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-01-07 22:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-01-07 22:07 [PATCH v2 0/2] Staging: unisys: visorbus: style fix Derek Robson
2017-01-07 22:08 ` [PATCH v2 1/2] Staging: unisys: visorbus: visorbus_main.c: fixed style Derek Robson
2017-01-07 22:08 ` [PATCH v2 2/2] Staging: unisys: visorbus: visorchipset.c: style fix Derek Robson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).