Re: [PATCH 0/3] fs: Support compiling out the pivot_root syscall

Nicolas Pitre
2017-02-25T15:18:07Z

On Fri, 24 Feb 2017, bosrsf04@gmail.com wrote:

> From: Brian Ashworth <bosrsf04@gmail.com>
>
> This patch series will allow for the pivot_root syscall to be made
> optional. The first patch refactors the functions that are required
> by pivot_root so they can be accessed outside of fs/namespace.c. The
> second patch moves the pivot_root syscall to its own file. The third
> adds a Kconfig option and conditional compilation to the Makefile.
>
> The pivot_root syscall is not needed on systems that do not use
> any intermediate filesystem. Allowing for pivot_root to be
> ommitted from the kernel will aid in the tinification efforts.

This looks good. Every such tiny bits count, and besides the size
reduction possibility this also makes the code clearer.

Acked-by: Nicolas Pitre <nico@linaro.org>

> Brian Ashworth (3):
> Makes functions used by pivot_root accessible
> Extracts pivot_root so it can be made optional
> Allows for the pivot_root syscall to be omitted
>
> fs/Makefile | 2 +
> fs/mount.h | 24 +++++++++
> fs/namespace.c | 150 +++-----------------------------------------------------
> fs/pivot_root.c | 129 ++++++++++++++++++++++++++++++++++++++++++++++++
> init/Kconfig | 10 ++++
> kernel/sys_ni.c | 1 +
> 6 files changed, 172 insertions(+), 144 deletions(-)
> create mode 100644 fs/pivot_root.c
>
> --
> 2.11.1
>
>