From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755363AbdCGKuH (ORCPT ); Tue, 7 Mar 2017 05:50:07 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:37567 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752233AbdCGKsu (ORCPT ); Tue, 7 Mar 2017 05:48:50 -0500 From: "Naveen N. Rao" To: Arnaldo Carvalho de Melo , Masami Hiramatsu Cc: Steven Rostedt , Ingo Molnar , linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Ananth N Mavinakayanahalli , Michael Ellerman Subject: Re: [PATCH v4 2/3] perf: kretprobes: offset from reloc_sym if kernel Date: Tue, 7 Mar 2017 16:17:35 +0530 X-Mailer: git-send-email 2.11.1 In-Reply-To: <20170306220638.e7db155d44e14325c5c0174b@kernel.org> References: <20170306220638.e7db155d44e14325c5c0174b@kernel.org> X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 17030710-7323-0000-0000-000000D33BE6 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17030710-7324-0000-0000-00000277A45D Message-Id: X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-03-07_07:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1702020001 definitions=main-1703070091 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2017/03/06 10:06PM, Masami Hiramatsu wrote: > On Mon, 6 Mar 2017 23:19:09 +0530 > "Naveen N. Rao" wrote: > > > Masami, > > Your patch works, thanks! However, I felt we could refactor and reuse > > some of the code across kprobes.c for this purpose. Can you please see > > if the below patch is fine? > > OK, looks good to me:) > > Acked-by: Masami Hiramatsu Thanks for the review, Masami! I ended up adding one more patch to this series (patch 5/6) to move the ftrace README scanning out of probe-file.c, as it doesn't need libelf. Patch 6 fails to build without libelf otherwise. Please take a look. Arnaldo, I am re-sending the remaining patches in this series which apply on top of the 4 patches you sent to Ingo, so as to keep this simple. All the patches have been acked, except the new patch 5/6. Kindly take a look. Thanks, Naveen -- Naveen N. Rao (6): trace/kprobes: fix check for kretprobe offset within function entry powerpc: kretprobes: override default function entry offset perf: probe: factor out the ftrace README scanning perf: kretprobes: offset from reloc_sym if kernel supports it perf: probes: move ftrace README parsing logic into trace-event-parse.c perf: powerpc: choose local entry point with kretprobes arch/powerpc/kernel/kprobes.c | 9 +++ include/linux/kprobes.h | 1 + kernel/kprobes.c | 40 ++++++++----- kernel/trace/trace_kprobe.c | 2 +- tools/perf/arch/powerpc/util/sym-handling.c | 10 ++-- tools/perf/util/probe-event.c | 12 ++-- tools/perf/util/probe-file.c | 80 +++----------------------- tools/perf/util/probe-file.h | 1 - tools/perf/util/trace-event-parse.c | 89 +++++++++++++++++++++++++++++ tools/perf/util/trace-event.h | 4 ++ 10 files changed, 149 insertions(+), 99 deletions(-) -- 2.11.1