From: Jose Abreu <Jose.Abreu@synopsys.com>
To: linux-media@vger.kernel.org
Cc: Jose Abreu <Jose.Abreu@synopsys.com>,
Carlos Palminha <CARLOS.PALMINHA@synopsys.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Hans Verkuil <hans.verkuil@cisco.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH 0/3] Handling of reduced FPS in V4L2
Date: Tue, 21 Mar 2017 11:49:15 +0000 [thread overview]
Message-ID: <cover.1490095965.git.joabreu@synopsys.com> (raw)
Hi all,
This is a follow up patch from this discussion [1]. It should be
seen more as a starting point to introduce better handling of
time per frame in v4l2. Quoting Hans Verkuil from [1]:
1) "Add a flag V4L2_DV_FL_CAN_DETECT_REDUCED_FPS. If set,
then the hw can detect the difference between regular fps
and 1000/1001 fps. Note: this is only valid for timings of
VIC codes with the V4L2_DV_FL_CAN_REDUCE_FPS flag set."
2) "Allow V4L2_DV_FL_REDUCED_FPS to be used for receivers
if V4L2_DV_FL_CAN_DETECT_REDUCED_FPS is set."
3) "For standard VIC codes the pixelclock returned by
query_dv_timings is that of the corresponding VIC timing,
not what is measured. This will ensure fixed fps values"
4) "g_parm should calculate the fps based on the v4l2_bt_timings
struct, looking at the REDUCES_FPS flags. For those receivers that
cannot detect the difference, the fps will be 24/30/60 Hz, for
those that can detect the difference g_parm can check if both
V4L2_DV_FL_CAN_DETECT_REDUCED_FPS and V4L2_DV_FL_REDUCED_FPS are
set and reduce the fps by 1000/1001."
-----------
In terms of implementation:
- Point 1) is done in patch 1/3
- Point 2) and 3) should be done by a HDMI Receiver driver
(I think?).
- Point 4) is done in patch 2/3.
- The patch 3/3 is a simple implementation (which was not
tested) in the cobalt driver
-----------
[1] https://patchwork.kernel.org/patch/9609441/
Best regards,
Jose Miguel Abreu
Cc: Carlos Palminha <palminha@synopsys.com>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: Hans Verkuil <hans.verkuil@cisco.com>
Cc: linux-media@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Jose Abreu (3):
[media] videodev2.h: Add new DV flag CAN_DETECT_REDUCED_FPS
[media] v4l2-dv-timings: Introduce v4l2_calc_timeperframe helper
[media] cobalt: Use v4l2_calc_timeperframe helper
drivers/media/pci/cobalt/cobalt-v4l2.c | 9 +++++--
drivers/media/v4l2-core/v4l2-dv-timings.c | 39 +++++++++++++++++++++++++++++++
include/media/v4l2-dv-timings.h | 11 +++++++++
include/uapi/linux/videodev2.h | 7 ++++++
4 files changed, 64 insertions(+), 2 deletions(-)
--
1.9.1
next reply other threads:[~2017-03-21 11:49 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-21 11:49 Jose Abreu [this message]
2017-03-21 11:49 ` [PATCH 1/3] [media] videodev2.h: Add new DV flag CAN_DETECT_REDUCED_FPS Jose Abreu
2017-03-21 11:49 ` [PATCH 2/3] [media] v4l2-dv-timings: Introduce v4l2_calc_timeperframe helper Jose Abreu
2017-03-21 11:49 ` [PATCH 3/3] [media] cobalt: Use " Jose Abreu
2017-03-30 13:42 ` Hans Verkuil
2017-03-31 8:59 ` Jose Abreu
2017-04-19 10:32 ` Jose Abreu
2017-03-24 11:03 ` [PATCH 0/3] Handling of reduced FPS in V4L2 Jose Abreu
2017-03-24 11:24 ` Hans Verkuil
2017-03-24 11:52 ` Jose Abreu
2017-03-24 12:12 ` Hans Verkuil
2017-03-24 12:21 ` Jose Abreu
2017-03-24 12:28 ` Hans Verkuil
2017-03-27 11:58 ` Jose Abreu
2017-03-28 10:07 ` Hans Verkuil
2017-03-29 13:26 ` Jose Abreu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1490095965.git.joabreu@synopsys.com \
--to=jose.abreu@synopsys.com \
--cc=CARLOS.PALMINHA@synopsys.com \
--cc=hans.verkuil@cisco.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox