From: Mauro Carvalho Chehab <mchehab@s-opensource.com>
To: Linux Doc Mailing List <linux-doc@vger.kernel.org>
Cc: Mauro Carvalho Chehab <mchehab@s-opensource.com>,
Mauro Carvalho Chehab <mchehab@infradead.org>,
linux-kernel@vger.kernel.org, Jonathan Corbet <corbet@lwn.net>,
Hans Verkuil <hverkuil@xs4all.nl>,
Stanimir Varbanov <stanimir.varbanov@linaro.org>,
Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Hans Verkuil <hans.verkuil@cisco.com>,
Kieran Bingham <kieran@ksquared.org.uk>,
Tomasz Figa <tfiga@chromium.org>
Subject: [PATCH 0/3] v4l2-compat-ioctl32.c: better detect pointer controls
Date: Thu, 10 Aug 2017 20:45:10 -0300 [thread overview]
Message-ID: <cover.1502408518.git.mchehab@s-opensource.com> (raw)
In-Reply-To: <f7340d67-cf7c-3407-e59a-aa0261185e82@xs4all.nl>
In the past, only string controls were pointers. That changed when compounded
types got added, but the compat32 code was not updated.
We could just add those controls there, but maintaining it is flaw, as we
often forget about the compat code. So, instead, rely on the control type,
as this is always updated when new controls are added.
As both v4l2-ctrl and compat32 code are at videodev.ko module, we can
move the ctrl_is_pointer() helper function to v4l2-ctrl.c.
Mauro Carvalho Chehab (3):
media: v4l2-ctrls.h: better document the arguments for v4l2_ctrl_fill
media: v4l2-ctrls: prepare the function to be used by compat32 code
media: compat32: reimplement ctrl_is_pointer()
drivers/media/v4l2-core/v4l2-compat-ioctl32.c | 18 +---------
drivers/media/v4l2-core/v4l2-ctrls.c | 49 +++++++++++++++++++++++++--
include/media/v4l2-ctrls.h | 28 ++++++++++-----
3 files changed, 67 insertions(+), 28 deletions(-)
--
2.13.3
next parent reply other threads:[~2017-08-10 23:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <f7340d67-cf7c-3407-e59a-aa0261185e82@xs4all.nl>
2017-08-10 23:45 ` Mauro Carvalho Chehab [this message]
2017-08-10 23:45 ` [PATCH 1/3] media: v4l2-ctrls.h: better document the arguments for v4l2_ctrl_fill Mauro Carvalho Chehab
2017-08-10 23:45 ` [PATCH 2/3] media: v4l2-ctrls: prepare the function to be used by compat32 code Mauro Carvalho Chehab
2017-08-10 23:45 ` [PATCH 3/3] media: compat32: reimplement ctrl_is_pointer() Mauro Carvalho Chehab
2017-08-10 23:52 ` [PATCH 0/3] v4l2-compat-ioctl32.c: better detect pointer controls Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1502408518.git.mchehab@s-opensource.com \
--to=mchehab@s-opensource.com \
--cc=corbet@lwn.net \
--cc=hans.verkuil@cisco.com \
--cc=hverkuil@xs4all.nl \
--cc=kieran@ksquared.org.uk \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@infradead.org \
--cc=sakari.ailus@linux.intel.com \
--cc=stanimir.varbanov@linaro.org \
--cc=tfiga@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox