public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Guillaume Douézan-Grard" <gdouezangrard@gmail.com>
To: Andy Shevchenko <andy@infradead.org>
Cc: Darren Hart <dvhart@infradead.org>,
	platform-driver-x86@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH v2 0/4] Topstar ACPI LED Workaround
Date: Sun, 29 Oct 2017 00:49:55 +0200	[thread overview]
Message-ID: <cover.1509229280.git.gdouezangrard@gmail.com> (raw)

Hi Andy,

Thank you for your review. Changes since the previous submission are
highlighted below.

On Topstar U931 Notebooks, an issue prevents the WLAN toggle key from
being properly managed by the Embedded Controller and successfully
disconnect the adapter. A specific ACPI method allows to toggle the WLAN
LED state regardless.

These are barebone laptops, sold under quite a lot of brands and
configurations, with different firmwares and so on. I can only say for sure
that this issue is present for all the models sold under a specific brand,
that's why I'm reluctant to enable this by default with a DMI check.

Thus, the new `led_workaround` option registers this LED with the
corresponding subsystem, making possible to use a software-based trigger
(rfkill for instance to synchronize the LED with the softkill state).

Thank you for your time,

--
Guillaume Douézan-Grard


Changes since v1:

* leave devices names unchanged for ABI compatibility,
* fix label names,
* separate module authors definition,
* add commit description to Patch 3.


Guillaume Douézan-Grard (4):
  platform/x86: topstar-laptop: non-functional changes
  platform/x86: topstar-laptop: change to generic module
  platform/x86: topstar-laptop: add platform device
  platform/x86: topstar-laptop: add optional WLAN LED workaround

 drivers/platform/x86/Kconfig          |   2 +
 drivers/platform/x86/topstar-laptop.c | 334 ++++++++++++++++++++++++++--------
 2 files changed, 265 insertions(+), 71 deletions(-)

-- 
2.14.3

             reply	other threads:[~2017-10-28 22:50 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-28 22:49 Guillaume Douézan-Grard [this message]
2017-10-28 22:50 ` [PATCH v2 1/4] platform/x86: topstar-laptop: non-functional changes Guillaume Douézan-Grard
2017-11-03 12:40   ` Andy Shevchenko
2017-10-28 22:51 ` [PATCH v2 2/4] platform/x86: topstar-laptop: change to generic module Guillaume Douézan-Grard
2017-11-03 12:43   ` Andy Shevchenko
2017-10-28 22:52 ` [PATCH v2 3/4] platform/x86: topstar-laptop: add platform device Guillaume Douézan-Grard
2017-11-03 12:47   ` Andy Shevchenko
2017-10-28 22:53 ` [PATCH v2 4/4] platform/x86: topstar-laptop: add optional WLAN LED workaround Guillaume Douézan-Grard
2017-11-03 12:50   ` Andy Shevchenko
2017-11-03 15:07     ` Guillaume Douézan-Grard
2017-11-05 13:28       ` Andy Shevchenko
2017-11-05 22:34         ` Darren Hart
2017-11-08  0:25           ` Guillaume Douézan-Grard
2017-11-08 10:26             ` Andy Shevchenko
2017-11-03 11:56 ` [PATCH v2 0/4] Topstar ACPI LED Workaround Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1509229280.git.gdouezangrard@gmail.com \
    --to=gdouezangrard@gmail.com \
    --cc=andy@infradead.org \
    --cc=dvhart@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox