From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751557AbdJ1WuG (ORCPT ); Sat, 28 Oct 2017 18:50:06 -0400 Received: from mail-wm0-f66.google.com ([74.125.82.66]:55525 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751304AbdJ1WuE (ORCPT ); Sat, 28 Oct 2017 18:50:04 -0400 X-Google-Smtp-Source: ABhQp+QVqwziOFKD0z7VE1J1bMy9TNXYxXBtiPDB4BQyzEoU2nEmNOrOBS0UMfEnpQNQzZv3ywq16w== Date: Sun, 29 Oct 2017 00:49:55 +0200 From: Guillaume =?utf-8?Q?Dou=C3=A9zan-Grard?= To: Andy Shevchenko Cc: Darren Hart , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 0/4] Topstar ACPI LED Workaround Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Andy, Thank you for your review. Changes since the previous submission are highlighted below. On Topstar U931 Notebooks, an issue prevents the WLAN toggle key from being properly managed by the Embedded Controller and successfully disconnect the adapter. A specific ACPI method allows to toggle the WLAN LED state regardless. These are barebone laptops, sold under quite a lot of brands and configurations, with different firmwares and so on. I can only say for sure that this issue is present for all the models sold under a specific brand, that's why I'm reluctant to enable this by default with a DMI check. Thus, the new `led_workaround` option registers this LED with the corresponding subsystem, making possible to use a software-based trigger (rfkill for instance to synchronize the LED with the softkill state). Thank you for your time, -- Guillaume Douézan-Grard Changes since v1: * leave devices names unchanged for ABI compatibility, * fix label names, * separate module authors definition, * add commit description to Patch 3. Guillaume Douézan-Grard (4): platform/x86: topstar-laptop: non-functional changes platform/x86: topstar-laptop: change to generic module platform/x86: topstar-laptop: add platform device platform/x86: topstar-laptop: add optional WLAN LED workaround drivers/platform/x86/Kconfig | 2 + drivers/platform/x86/topstar-laptop.c | 334 ++++++++++++++++++++++++++-------- 2 files changed, 265 insertions(+), 71 deletions(-) -- 2.14.3