Re: [PATCH 04/14] nubus: Fix log spam

Joe Perches
2017-11-11T15:04:14Z

On Sat, 2017-11-11 at 01:12 -0500, Finn Thain wrote:
> Testing shows that a single Radius PrecisionColor 24X display board,
> which has 95 functional resources, produces over a thousand lines of
> log messages. Suppress these messages with pr_debug().
> Remove some redundant messages relating to nubus_get_subdir() calls.
> Fix the format block debug messages which has the sequence of entries
> backwards (my bad).
> Move the "Scanning slots" message to its proper location.

pr_debug calls are compiled completely away to nothing
unless DEBUG is
defined or CONFIG_DYNAMIC_DEBUG is
enabled.

Aren't some of these actually useful?

Perhaps it'd be nicer to have some nubus
specific flag to enable these outputs instead
of relying on either #define DEBUG or
CONFIG_DYNAMIC_DEBUG?